Bug 15565 - Place multiple holds at once for the same record
Summary: Place multiple holds at once for the same record
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Arnaud
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 14695
Blocks: 15567
  Show dependency treegraph
 
Reported: 2016-01-13 13:10 UTC by Julian Maurice
Modified: 2018-04-19 06:17 UTC (History)
19 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (36.02 KB, patch)
2016-02-01 17:23 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.00 KB, patch)
2016-02-02 13:12 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - CSS changes (80.75 KB, patch)
2016-02-02 13:12 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (36.99 KB, patch)
2016-04-08 11:14 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bz 15565 - CSS changes (80.77 KB, patch)
2016-04-08 11:15 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.23 KB, patch)
2016-04-19 10:16 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.41 KB, patch)
2016-04-19 10:17 UTC, Julian Maurice
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-12 08:17 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - CSS changes (80.77 KB, patch)
2016-10-12 08:17 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.26 KB, patch)
2016-10-12 08:17 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.41 KB, patch)
2016-10-12 08:17 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (941 bytes, patch)
2016-10-14 07:56 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (995 bytes, patch)
2016-10-14 12:20 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-14 12:26 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - CSS changes (80.77 KB, patch)
2016-10-14 12:26 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.26 KB, patch)
2016-10-14 12:26 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.41 KB, patch)
2016-10-14 12:26 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (995 bytes, patch)
2016-10-14 12:26 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-14 12:51 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-14 12:53 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-14 12:58 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.65 KB, patch)
2016-10-14 13:03 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - CSS changes (80.77 KB, patch)
2016-10-14 13:04 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.26 KB, patch)
2016-10-14 13:06 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.46 KB, patch)
2016-10-14 13:06 UTC, Danielle Elder
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.03 KB, patch)
2016-10-14 13:08 UTC, Danielle Elder
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.35 KB, patch)
2017-03-20 08:09 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - CSS changes (81.47 KB, patch)
2017-03-20 08:09 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.26 KB, patch)
2017-03-20 08:10 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.46 KB, patch)
2017-03-20 08:10 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.03 KB, patch)
2017-03-20 08:10 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.50 KB, patch)
2017-03-23 16:17 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bz 15565 - CSS changes (81.62 KB, patch)
2017-03-23 16:17 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.40 KB, patch)
2017-03-23 16:17 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.61 KB, patch)
2017-03-23 16:17 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.24 KB, patch)
2017-03-23 16:17 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.57 KB, patch)
2017-06-23 12:48 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - CSS changes (82.01 KB, patch)
2017-06-23 12:48 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.40 KB, patch)
2017-06-23 12:48 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.61 KB, patch)
2017-06-23 12:48 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.24 KB, patch)
2017-06-23 12:49 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.40 KB, patch)
2017-08-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bz 15565 - CSS changes (82.01 KB, patch)
2017-08-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.40 KB, patch)
2017-08-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.61 KB, patch)
2017-08-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.24 KB, patch)
2017-08-29 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.46 KB, patch)
2017-10-27 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15565 - CSS changes (82.07 KB, patch)
2017-10-27 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.46 KB, patch)
2017-10-27 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.67 KB, patch)
2017-10-27 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.29 KB, patch)
2017-10-27 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.47 KB, patch)
2018-02-15 11:13 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565 - CSS changes (84.98 KB, patch)
2018-02-15 11:14 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.46 KB, patch)
2018-02-15 11:14 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.67 KB, patch)
2018-02-15 11:14 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.29 KB, patch)
2018-02-15 11:14 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565 - remove use of GetBiblionumberFromItemnumber (968 bytes, patch)
2018-02-15 11:14 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 15565 - Place multiple holds at once for the same record on staff and OPAC. (37.53 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565 - CSS changes (85.04 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565: Use item's biblionumber only on item-level request (1.52 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off (1.73 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565: Alert librarian that maximum holds per record is reached (1.35 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review
Bug 15565 - remove use of GetBiblionumberFromItemnumber (1.01 KB, patch)
2018-03-12 11:04 UTC, Benjamin Rokseth
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-01-13 13:10:53 UTC
Bug 14695 allows to place multiple item-level holds for the same record.
It would be nice to also have the ability to place multiple title-level holds for the same record.
An example use case could be a teacher that wants to borrow multiple copies of the same book for his students.
Comment 1 Alex Arnaud 2016-01-27 16:53:33 UTC
Bug 14695 allows to place multiple holds for the same record. It would be nice to choose the numbers of items (or select several items) at once instead of making X times the same operation. We want this behavior on staff and OPAC.
Comment 2 Alex Arnaud 2016-02-01 17:23:40 UTC Comment hidden (obsolete)
Comment 3 Alex Arnaud 2016-02-02 13:12:42 UTC Comment hidden (obsolete)
Comment 4 Alex Arnaud 2016-02-02 13:12:48 UTC Comment hidden (obsolete)
Comment 5 Nick Clemens 2016-03-04 22:12:29 UTC
/home/vagrant/kohaclone/.git/rebase-apply/patch:432: trailing whitespace.
my @biblionumbers = ref($query->param('biblionumbers')) eq 'Array' 
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Comment 6 Benjamin Rokseth 2016-04-08 11:14:52 UTC Comment hidden (obsolete)
Comment 7 Benjamin Rokseth 2016-04-08 11:15:01 UTC Comment hidden (obsolete)
Comment 8 Benjamin Rokseth 2016-04-08 11:15:32 UTC
Rebased against master
Comment 9 Benjamin Rokseth 2016-04-08 12:18:51 UTC
Fails in intra on placing any number of holds with:

/cgi-bin/koha/reserve/placerequest.pl
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'biblionumber' cannot be null at /kohadev/kohaclone/Koha/Object.pm line 109

I notice that in the request, param multi_holds is not present
Comment 10 Julian Maurice 2016-04-19 10:16:59 UTC Comment hidden (obsolete)
Comment 11 Julian Maurice 2016-04-19 10:17:03 UTC Comment hidden (obsolete)
Comment 12 Julian Maurice 2016-04-19 10:17:51 UTC
(In reply to Benjamin Rokseth from comment #9)
> Fails in intra on placing any number of holds with:
> 
> /cgi-bin/koha/reserve/placerequest.pl
> DBIx::Class::Storage::DBI::_dbh_execute(): Column 'biblionumber' cannot be
> null at /kohadev/kohaclone/Koha/Object.pm line 109
attachment 50392 [details] [review] fixes that
Comment 13 Benjamin Rokseth 2016-05-06 11:20:53 UTC
1 out of 7 hunks FAILED -- saving rejects to file opac/opac-reserve.pl.rej
...
2 out of 3 hunks FAILED -- saving rejects to file reserve/placerequest.pl.rej

seems to conflict with Bug 15533 - Allow patrons and librarians to select itemtype when placing holds pushed recently?
Comment 14 Jonathan Druart 2016-06-08 14:58:53 UTC
Alex, could you confirm that you will abandon your patches in favor of the ones on bug 14695?
Comment 15 Jonathan Druart 2016-06-08 14:59:55 UTC
(In reply to Jonathan Druart from comment #14)
> Alex, could you confirm that you will abandon your patches in favor of the
> ones on bug 14695?

Sorry, misread, forget that.
Comment 16 Alex Arnaud 2016-10-12 08:17:01 UTC Comment hidden (obsolete)
Comment 17 Alex Arnaud 2016-10-12 08:17:11 UTC Comment hidden (obsolete)
Comment 18 Alex Arnaud 2016-10-12 08:17:21 UTC Comment hidden (obsolete)
Comment 19 Alex Arnaud 2016-10-12 08:17:30 UTC Comment hidden (obsolete)
Comment 20 Alex Arnaud 2016-10-12 13:04:24 UTC
Patches have been rebased on master. Please test.
Comment 21 Séverine Queune 2016-10-12 13:33:55 UTC
There is no alert when exceeding the maximum of holds per record, but Koha places holds only in the number of items fixed in the circ rules.
I think it should react like when maximum holds allowed is reached : checkbox can't be selected.
Comment 22 Alex Arnaud 2016-10-14 07:56:47 UTC Comment hidden (obsolete)
Comment 23 Danielle Elder 2016-10-14 12:20:15 UTC Comment hidden (obsolete)
Comment 24 Danielle Elder 2016-10-14 12:26:11 UTC Comment hidden (obsolete)
Comment 25 Danielle Elder 2016-10-14 12:26:19 UTC
Created attachment 56512 [details] [review]
Bz 15565 - CSS changes
Comment 26 Danielle Elder 2016-10-14 12:26:25 UTC Comment hidden (obsolete)
Comment 27 Danielle Elder 2016-10-14 12:26:31 UTC Comment hidden (obsolete)
Comment 28 Danielle Elder 2016-10-14 12:26:39 UTC Comment hidden (obsolete)
Comment 29 Danielle Elder 2016-10-14 12:51:23 UTC Comment hidden (obsolete)
Comment 30 Danielle Elder 2016-10-14 12:53:20 UTC Comment hidden (obsolete)
Comment 31 Danielle Elder 2016-10-14 12:58:20 UTC Comment hidden (obsolete)
Comment 32 Danielle Elder 2016-10-14 13:03:23 UTC Comment hidden (obsolete)
Comment 33 Danielle Elder 2016-10-14 13:04:39 UTC Comment hidden (obsolete)
Comment 34 Danielle Elder 2016-10-14 13:06:03 UTC Comment hidden (obsolete)
Comment 35 Danielle Elder 2016-10-14 13:06:29 UTC Comment hidden (obsolete)
Comment 36 Danielle Elder 2016-10-14 13:08:13 UTC
Sorry, devbox trouble with multiple sign-offs.  I did test and received the alert when I tried too many holds per record, but was able to place holds on multiple items per bib.
Comment 37 Danielle Elder 2016-10-14 13:08:28 UTC Comment hidden (obsolete)
Comment 38 Alex Arnaud 2017-03-20 08:09:42 UTC Comment hidden (obsolete)
Comment 39 Alex Arnaud 2017-03-20 08:09:52 UTC Comment hidden (obsolete)
Comment 40 Alex Arnaud 2017-03-20 08:10:05 UTC Comment hidden (obsolete)
Comment 41 Alex Arnaud 2017-03-20 08:10:16 UTC Comment hidden (obsolete)
Comment 42 Alex Arnaud 2017-03-20 08:10:30 UTC Comment hidden (obsolete)
Comment 43 sandboxes@biblibre.com 2017-03-23 16:16:14 UTC
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Comment 44 sandboxes@biblibre.com 2017-03-23 16:17:19 UTC Comment hidden (obsolete)
Comment 45 sandboxes@biblibre.com 2017-03-23 16:17:24 UTC Comment hidden (obsolete)
Comment 46 sandboxes@biblibre.com 2017-03-23 16:17:28 UTC Comment hidden (obsolete)
Comment 47 sandboxes@biblibre.com 2017-03-23 16:17:32 UTC Comment hidden (obsolete)
Comment 48 sandboxes@biblibre.com 2017-03-23 16:17:36 UTC Comment hidden (obsolete)
Comment 49 Alex Arnaud 2017-06-23 12:48:23 UTC Comment hidden (obsolete)
Comment 50 Alex Arnaud 2017-06-23 12:48:34 UTC Comment hidden (obsolete)
Comment 51 Alex Arnaud 2017-06-23 12:48:45 UTC Comment hidden (obsolete)
Comment 52 Alex Arnaud 2017-06-23 12:48:55 UTC Comment hidden (obsolete)
Comment 53 Alex Arnaud 2017-06-23 12:49:04 UTC Comment hidden (obsolete)
Comment 54 Owen Leonard 2017-08-29 17:52:24 UTC Comment hidden (obsolete)
Comment 55 Owen Leonard 2017-08-29 17:52:29 UTC Comment hidden (obsolete)
Comment 56 Owen Leonard 2017-08-29 17:52:33 UTC Comment hidden (obsolete)
Comment 57 Owen Leonard 2017-08-29 17:52:38 UTC Comment hidden (obsolete)
Comment 58 Owen Leonard 2017-08-29 17:52:43 UTC Comment hidden (obsolete)
Comment 59 Liz Rea 2017-10-04 02:38:59 UTC
This still applies, could we get a QA to look at it please? Really good feature.

Cheers,
Liz
Comment 60 Kyle M Hall 2017-10-27 15:59:52 UTC Comment hidden (obsolete)
Comment 61 Kyle M Hall 2017-10-27 16:00:02 UTC Comment hidden (obsolete)
Comment 62 Kyle M Hall 2017-10-27 16:00:07 UTC Comment hidden (obsolete)
Comment 63 Kyle M Hall 2017-10-27 16:00:12 UTC Comment hidden (obsolete)
Comment 64 Kyle M Hall 2017-10-27 16:00:16 UTC Comment hidden (obsolete)
Comment 65 Jonathan Druart 2017-10-27 20:19:06 UTC
Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_opac_opac_2dreserve_2epl::GetBiblionumberFromItemnumber called at /home/vagrant/kohaclone/opac/opac-reserve.pl line 244.


This subroutine has been removed on bug 18277.
Comment 66 Liz Rea 2018-02-01 20:30:15 UTC
Hi,

Lots of conflicts applying this now.

Cheers,
Liz
Comment 67 Chris Cormack 2018-02-01 22:11:46 UTC
We'd really like this patch in, does Biblibre plan to work on it more, if not please let us know so we can perhaps try to get it fixed to pass QA ourselves
Comment 68 Alex Arnaud 2018-02-15 11:13:57 UTC
Created attachment 71643 [details] [review]
Bug 15565 - Place multiple holds at once for the same record on staff and OPAC.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 69 Alex Arnaud 2018-02-15 11:14:09 UTC
Created attachment 71644 [details] [review]
Bug 15565 - CSS changes

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 70 Alex Arnaud 2018-02-15 11:14:20 UTC
Created attachment 71645 [details] [review]
Bug 15565: Use item's biblionumber only on item-level request

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 71 Alex Arnaud 2018-02-15 11:14:30 UTC
Created attachment 71646 [details] [review]
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off

Signed-off-by: Danielle Elder <danielle@bywatersolution.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 72 Alex Arnaud 2018-02-15 11:14:42 UTC
Created attachment 71647 [details] [review]
Bug 15565: Alert librarian that maximum holds per record is reached

Signed-off-by: Dani Elder <dani@bywatersolutions.com>

Signed-off-by: Danielle Elder <danielle@bywatersolution.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 73 Alex Arnaud 2018-02-15 11:14:52 UTC
Created attachment 71648 [details] [review]
Bug 15565 - remove use of GetBiblionumberFromItemnumber
Comment 74 Benjamin Rokseth 2018-03-12 11:04:02 UTC
Created attachment 72644 [details] [review]
Bug 15565 - Place multiple holds at once for the same record on staff and OPAC.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 75 Benjamin Rokseth 2018-03-12 11:04:13 UTC
Created attachment 72645 [details] [review]
Bug 15565 - CSS changes

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 76 Benjamin Rokseth 2018-03-12 11:04:23 UTC
Created attachment 72646 [details] [review]
Bug 15565: Use item's biblionumber only on item-level request

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 77 Benjamin Rokseth 2018-03-12 11:04:31 UTC
Created attachment 72647 [details] [review]
Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off

Signed-off-by: Danielle Elder <danielle@bywatersolution.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 78 Benjamin Rokseth 2018-03-12 11:04:41 UTC
Created attachment 72648 [details] [review]
Bug 15565: Alert librarian that maximum holds per record is reached

Signed-off-by: Dani Elder <dani@bywatersolutions.com>

Signed-off-by: Danielle Elder <danielle@bywatersolution.com>

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 79 Benjamin Rokseth 2018-03-12 11:04:51 UTC
Created attachment 72649 [details] [review]
Bug 15565 - remove use of GetBiblionumberFromItemnumber

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no>
Comment 80 Katrin Fischer 2018-04-16 22:51:20 UTC
Hi Alex,

patch applies, QA script passes. Bit baffled there are no changes to C4/Koha and no unit tests.

Can you please amend the first patch with a proper test plan and fix the commit messages? (Bug XXXX:)
Comment 81 Katrin Fischer 2018-04-19 06:17:10 UTC
Ping?