Bugzilla – Attachment 163717 Details for
Bug 36394
Inconsistent behaviour in footers (mappings admin page)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36394: Fix footers behaviour on the ES mapping page
Bug-36394-Fix-footers-behaviour-on-the-ES-mapping-.patch (text/plain), 5.85 KB, created by
ByWater Sandboxes
on 2024-03-22 15:58:08 UTC
(
hide
)
Description:
Bug 36394: Fix footers behaviour on the ES mapping page
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-03-22 15:58:08 UTC
Size:
5.85 KB
patch
obsolete
>From ac43fa77ed4f328005acc2155dcb756b432c6755 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Mar 2024 14:16:23 +0100 >Subject: [PATCH] Bug 36394: Fix footers behaviour on the ES mapping page > >In the footers of the tables of the search fields and mappings, >the options selected are not consistent. >Additionally they are not reset correctly when a new line is added. > >Test plan: >0. Do not apply to recreate the problem >1. Go to the ES mapping page >2. Click tab "Bibliographic records" >3. At the bottom, notice the Yes/No dropdown lists >=> They are inconsistent, sometimes 'Yes', sometimes 'No' >4. Click Add >=> Values are kept > >5. Apply this patch >6. Repeat 1, 2, 3 >=> No (first option) is always selected >7. Click Add after you modified some values >=> "No" is selected > >Sponsored-by: The Research University in the Helmholtz Association (KIT) >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> >--- > .../searchengine/elasticsearch/mappings.tt | 36 +++++-------------- > .../prog/js/elasticsearch-mappings.js | 2 +- > 2 files changed, 9 insertions(+), 29 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index 164bf6f7c4..984e6c8518 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -404,46 +404,26 @@ a.add, a.delete { > </td> > <td> > <select data-id="mapping_facet"> >- [% IF mapping.facet %] >- <option value="0">No</option> >- <option value="1" selected="selected">Yes</option> >- [% ELSE %] >- <option value="0" selected="selected">No</option> >- <option value="1">Yes</option> >- [% END %] >+ <option value="0">No</option> >+ <option value="1">Yes</option> > </select> > </td> > <td> > <select data-id="mapping_suggestible"> >- [% IF mapping.suggestible %] >- <option value="0">No</option> >- <option value="1" selected="selected">Yes</option> >- [% ELSE %] >- <option value="0" selected="selected">No</option> >- <option value="1">Yes</option> >- [% END %] >+ <option value="0">No</option> >+ <option value="1">Yes</option> > </select> > </td> > <td> > <select data-id="mapping_search"> >- [% IF mapping.search %] >- <option value="0">No</option> >- <option value="1" selected="selected">Yes</option> >- [% ELSE %] >- <option value="0" selected="selected">No</option> >- <option value="1">Yes</option> >- [% END %] >+ <option value="0">No</option> >+ <option value="1">Yes</option> > </select> > </td> > <td> > <select name="mapping_filter"> >- [% IF mapping.filter == 'punctuation' %] >- <option value="">None</option> >- <option value="punctuation" selected="selected">Punctuation</option> >- [% ELSE %] >- <option value="" selected="selected">None</option> >- <option value="punctuation">Punctuation</option> >- [% END %] >+ <option value="">None</option> >+ <option value="punctuation">Punctuation</option> > </select> > </td> > <td><input data-id="mapping_marc_field" type="text" /></td> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >index 696d8d5cf7..b40fec0f45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >@@ -2,7 +2,7 @@ > > function clean_line(line) { > $(line).find('input[type="text"]').val(""); >- $(line).find('select').find('option:first').attr("selected", "selected"); >+ $(line).find('select').find('option:first').prop("selected", true); > } > > function clone_line(line) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36394
:
163678
|
163717
|
164202
|
164203