Bugzilla – Attachment 164020 Details for
Bug 36227
No warning if placing hold on item group with no items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36227: Remove item group option if there are no items
Bug-36227-Remove-item-group-option-if-there-are-no.patch (text/plain), 1.95 KB, created by
Lucas Gass (lukeg)
on 2024-03-27 17:47:22 UTC
(
hide
)
Description:
Bug 36227: Remove item group option if there are no items
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-03-27 17:47:22 UTC
Size:
1.95 KB
patch
obsolete
>From ae0914c9d9f617900bb5a4e893e7f07bef71c07b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 6 Mar 2024 00:32:03 +0000 >Subject: [PATCH] Bug 36227: Remove item group option if there are no items > >To test: >1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 58f1397012..5f3ea2691b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -320,7 +320,9 @@ > <select name="item_group_id_[% bibitemloo.biblionumber | html %]" id="item_group_id_[% bibitemloo.biblionumber | html %]"> > <option value="">Any item group</option> > [% FOREACH g IN bibitemloo.object.item_groups.search({}, { order_by => ['display_order'] }) %] >- <option value="[% g.id | html %]">[% g.description | html %]</option> >+ [% IF g.items.count %] >+ <option value="[% g.id | html %]">[% g.description | html %]</option> >+ [% END %] > [% END %] > </select> > </li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36227
:
162806
|
162807
|
162851
|
162852
|
164019
|
164020
|
164030
|
164031