It is currently possible to place a group-level hold on an item group with no items in it, both from the staff client and OPAC. This results in a hold that is not fillable unless the item group is deleted or an item is added into it. A warning would be helpful so patrons aren't left with an unfillable hold.
Created attachment 162806 [details] [review] Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work.
Created attachment 162807 [details] [review] Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown
Created attachment 162851 [details] [review] Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 162852 [details] [review] Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Patch does not apply (probably needs to be rebased on top of 34478)
Created attachment 164019 [details] [review] Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 164020 [details] [review] Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Rebased for current master.
Created attachment 164030 [details] [review] Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 164031 [details] [review] Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12