Bugzilla – Attachment 164287 Details for
Bug 35856
Runtime parameter modal should provide option of ":all"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35856: (follow-up) Expand display of radio button choices
Bug-35856-follow-up-Expand-display-of-radio-button.patch (text/plain), 4.05 KB, created by
Owen Leonard
on 2024-04-02 17:24:13 UTC
(
hide
)
Description:
Bug 35856: (follow-up) Expand display of radio button choices
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-04-02 17:24:13 UTC
Size:
4.05 KB
patch
obsolete
>From 1be02ca9afd47c1cf9c8607f691a46a5f22c3352 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 28 Mar 2024 12:00:14 +0000 >Subject: [PATCH] Bug 35856: (follow-up) Expand display of radio button choices > >This patch swaps out the icons with tooltips with visible hints, >expanding the radio button options to hopefully make it more readable. >--- > .../modules/reports/guided_reports_start.tt | 32 ++++++++++++------- > 1 file changed, 21 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index bc2181fb13..322c759ab3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -74,6 +74,10 @@ > .data-plain { > display: none; > } >+ div.radio label { >+ font-weight: bold; >+ margin: 0; >+ } > </style> > [% Asset.css("css/reports.css") | $raw %] > [% Asset.css("lib/d3c3/c3.min.css") | $raw %] >@@ -1513,17 +1517,23 @@ > <div class="hint">Select which authorized value category the user will choose from.</div> > </div> > <div id="runtime_param_options" style="display:none"> >- <label>Parameter options:</label> >- <div class="form-check-inline"> >- <input type="radio" class="form-check-input" id="single_param_check" name="param_option" value="" checked> >- <label class="form-check-label" for="single_param_check">Single parameter only</label> >- <i id="info_param_options" data-toggle="tooltip" title="" data-placement="top" class="fa fa-info-circle" data-original-title="Query expression should use ="></i> >- <input type="radio" class="form-check-input" id="include_all_check" name="param_option" value=":all"> >- <label class="form-check-label" for="include_all_check">Include option for all</label> >- <i id="info_param_options" data-toggle="tooltip" title="" data-placement="top" class="fa fa-info-circle" data-original-title="Query expression must use LIKE"></i> >- <input type="radio" class="form-check-input" id="multi_select_check" name="param_option" value=":in"> >- <label class="form-check-label" for="multi_select_check">Allow multiple selections</label> >- <i id="info_param_options" data-toggle="tooltip" title="" data-placement="top" class="fa fa-info-circle" data-original-title="Query expression must use IN"></i> >+ <h5>Parameter options:</h5> >+ <div class="radio"> >+ <input type="radio" id="single_param_check" name="param_option" value="" checked="checked" /> >+ <label for="single_param_check">Single parameter only</label> >+ <span class="hint">- Query expression should use =</span> >+ </div> >+ >+ <div class="radio"> >+ <input type="radio" id="include_all_check" name="param_option" value=":all"> >+ <label for="include_all_check">Include option for all</label> >+ <span class="hint">- Query expression must use LIKE</span> >+ </div> >+ >+ <div class="radio"> >+ <input type="radio" id="multi_select_check" name="param_option" value=":in"> >+ <label for="multi_select_check">Allow multiple selections</label> >+ <span class="hint">- Query expression must use IN</span> > </div> > </div> > </div> <!-- /.modal-body --> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35856
:
161357
|
162306
|
162307
|
162308
|
164050
| 164287