Bug 35856 - Runtime parameter modal should provide option of ":all"
Summary: Runtime parameter modal should provide option of ":all"
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on: 35746
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-22 15:31 UTC by Andrew Fuerste-Henry
Modified: 2024-04-03 16:46 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35856: added options to runtime parameter modal (7.21 KB, patch)
2024-01-24 18:02 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 35856: added options to runtime parameter modal (7.28 KB, patch)
2024-02-20 17:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35856: added options to runtime parameter modal (8.03 KB, patch)
2024-02-20 17:47 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 35856: added options to runtime parameter modal (8.10 KB, patch)
2024-02-20 20:36 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35856: added options to runtime parameter modal (8.16 KB, patch)
2024-03-28 11:35 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 35856: (follow-up) Expand display of radio button choices (4.05 KB, patch)
2024-04-02 17:24 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-01-22 15:31:04 UTC
The modal interface to insert a runtime parameters should offer the option to make one's parameter offer the "All" option. Currently, use of the All feature requires one to manually add ":all" at the end of the parameter and is not clearly suggested by anything in the interface. The modal could include a checkbox one could check to add ":all" to the constructed parameter. It would probably be helpful to display some text reminding the user that one must use LIKE rather than = with ":all."

I've made this depend on bug 35746, which adds an ":in" option. If that gets pushed, it'd be great to have it included as an option in the modal, too.
Comment 1 Brendan Lawlor 2024-01-24 18:02:22 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2024-01-25 23:46:22 UTC
Should this be 'Signed-off'? I don't see am attached patch/sign-off line. Setting this back to NSO.
Comment 3 Caroline Cyr La Rose 2024-02-20 17:31:03 UTC Comment hidden (obsolete)
Comment 4 Caroline Cyr La Rose 2024-02-20 17:32:07 UTC
Very exciting!

In documentation, we should mention that :in requires IN and :all requires LIKE. Otherwise, the reports don't work.
Comment 5 Brendan Lawlor 2024-02-20 17:47:50 UTC Comment hidden (obsolete)
Comment 6 Brendan Lawlor 2024-02-20 17:51:10 UTC
Thanks Caroline!

I just made a small update to the patch that adds a default check box for choosing a single parameter plus some tool tips to explain the need for using =, LIKE and IN in the query expression.
Comment 7 Caroline Cyr La Rose 2024-02-20 20:36:26 UTC Comment hidden (obsolete)
Comment 8 Caroline Cyr La Rose 2024-02-20 20:37:22 UTC
Thanks Brendan! 

I was mentioning it for the documentation team when we'll add it to the manual, but this is good too! :)

Caroline
Comment 9 Nick Clemens 2024-03-28 11:35:12 UTC
Created attachment 164050 [details] [review]
Bug 35856: added options to runtime parameter modal

This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in.

The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Test plan:
1. Apply patch
2. Create a report from SQL
3. Click Insert runtime parameter and choose any option other than date, list or text field
4. Note the form now includes a radio checkbox for parameter options
5. Choose 'Include option for all' and click Insert parameter
6. Note the parameter is inserted with :all option like <<label|authval:all>>
7. Choose 'Allow multiple selections' and click Insert parameter
8. Note the parameter is inserted with :in option like <<label|authval:in>>
9. Make sure that parameter options are not included on the form for date, list and text field

Thanks!

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Owen Leonard 2024-04-02 17:24:13 UTC
Created attachment 164287 [details] [review]
Bug 35856: (follow-up) Expand display of radio button choices

This patch swaps out the icons with tooltips with visible hints,
expanding the radio button options to hopefully make it more readable.
Comment 11 Brendan Lawlor 2024-04-03 16:46:10 UTC
Thanks Owen! I like the vertical layout of the radio buttons. It's much easier to read.