The modal interface to insert a runtime parameters should offer the option to make one's parameter offer the "All" option. Currently, use of the All feature requires one to manually add ":all" at the end of the parameter and is not clearly suggested by anything in the interface. The modal could include a checkbox one could check to add ":all" to the constructed parameter. It would probably be helpful to display some text reminding the user that one must use LIKE rather than = with ":all." I've made this depend on bug 35746, which adds an ":in" option. If that gets pushed, it'd be great to have it included as an option in the modal, too.
Created attachment 161357 [details] [review] Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks!
Should this be 'Signed-off'? I don't see am attached patch/sign-off line. Setting this back to NSO.
Created attachment 162306 [details] [review] Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Very exciting! In documentation, we should mention that :in requires IN and :all requires LIKE. Otherwise, the reports don't work.
Created attachment 162307 [details] [review] Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks!
Thanks Caroline! I just made a small update to the patch that adds a default check box for choosing a single parameter plus some tool tips to explain the need for using =, LIKE and IN in the query expression.
Created attachment 162308 [details] [review] Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Brendan! I was mentioning it for the documentation team when we'll add it to the manual, but this is good too! :) Caroline
Created attachment 164050 [details] [review] Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 164287 [details] [review] Bug 35856: (follow-up) Expand display of radio button choices This patch swaps out the icons with tooltips with visible hints, expanding the radio button options to hopefully make it more readable.
Thanks Owen! I like the vertical layout of the radio buttons. It's much easier to read.
Depends on a patch currently in Failed QA - please bring these back to my queue soon!
I struggle a tiny bit with the phrasing "Query expression". Hm, but what to write instead? A suggestion: Query condition must use ... operator. What do you think? (setting additional_work_needed to highlight the question)
Pushed for 24.05! Well done everyone, thank you!