Bugzilla – Attachment 164951 Details for
Bug 35925
Port default NEW_SUGGESTION, REJECTED, ACCEPTED, and ORDERED notices to Template Toolkit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35925: Adjust default purchase suggestion notices to use TT
Bug-35925-Adjust-default-purchase-suggestion-notic.patch (text/plain), 8.52 KB, created by
Emily Lamancusa (emlam)
on 2024-04-16 14:44:43 UTC
(
hide
)
Description:
Bug 35925: Adjust default purchase suggestion notices to use TT
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-04-16 14:44:43 UTC
Size:
8.52 KB
patch
obsolete
>From ec6b8724afa3d1d335628e21f0b0b7e5185145fd Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Mon, 15 Apr 2024 17:48:46 -0400 >Subject: [PATCH] Bug 35925: Adjust default purchase suggestion notices to use > TT > >1. Apply patch >2. reset_all (or start your testing environment in the first place) >3. Set syspref EmailPurchaseSuggestions to "email address of library" >4. Under Administration > Libraries, enter an email address for at least > one library >5. Go to "my account", and enter a Primary email and Phone number >6. Go to the Acquisitions module > Suggestions page >7. Click "New purchase suggestion", and fill in values for, at minimum: > Bibliographic information: > Title > Author > Copyright date > ISBN/ISSN > Publisher > Publication place > Collection title > Document type > Reason for suggestion > Notes > Acquisition information: > Library (set to the library you entered an email for in step 4) > Copies >8. Submit the suggestion >9. Set the suggestion status to "Rejected" > a. Check the checkbox next to the suggestion > b. Set the "Mark selected as" drop-down (below the table) to Rejected > c. Select a value for the "Reason" drop-down > d. Click the Submit button >10. Set the suggestion status to "Accepted" (as above) >11. Set the suggestion status to "Ordered" (as above) >12. Return to "my account" and open the Notices tab >--> There should be notices suggestion declined, suggestion accepted, > suggestion ordered, and (depending on settings) new suggestion* >13. Open each notice, and confirm the all information was filled in > correctly > >* New suggestion will be there if you're using default KTD settings/data >and logged in as the root user. If it is not there, query the database >(by command line or SQL report) to see the generated notice text: >SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION' >--- > .../mysql/en/mandatory/sample_notices.yml | 62 ++++++++++--------- > 1 file changed, 33 insertions(+), 29 deletions(-) > >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index 9675b3eb4f..6c1f80cee7 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1962,17 +1962,17 @@ tables: > message_transport_type: email > lang: default > content: >- - "Dear <<borrowers.firstname>> <<borrowers.surname>>," >+ - "Dear [% borrower.firstname %] [% borrower.surname %]," > - "" >- - "You have suggested that the library acquire <<suggestions.title>> by <<suggestions.author>>." >+ - "You have suggested that the library acquire [% suggestion.title %] by [% suggestion.author %]." > - "" > - "The library has reviewed your suggestion today. The item will be ordered as soon as possible. You will be notified by mail when the order is completed, and again when the item arrives at the library." > - "" >- - "If you have any questions, please email us at <<branches.branchemail>>." >+ - "If you have any questions, please email us at [% branch.branchemail %]." > - "" > - "Thank you," > - "" >- - "<<branches.branchname>>" >+ - "[% branch.branchname %]" > > - module: suggestions > code: AVAILABLE >@@ -2007,26 +2007,30 @@ tables: > - "<h3>Suggestion pending approval</h3>" > - " <p><h4>Suggested by</h4>" > - " <ul>" >- - " <li><<borrowers.firstname>> <<borrowers.surname>></li>" >- - " <li><<borrowers.cardnumber>></li>" >- - " <li><<borrowers.phone>></li>" >- - " <li><<borrowers.email>></li>" >+ - " <li>[% borrower.firstname %] [% borrower.surname %]</li>" >+ - " <li>[% borrower.cardnumber %]</li>" >+ - " [%- IF borrower.phone -%]" >+ - " <li>[% borrower.phone %]</li>" >+ - " [%- END -%]" >+ - " [%- IF borrower.email -%]" >+ - " <li>[% borrower.email %]</li>" >+ - " [%- END -%]" > - " </ul>" > - " </p>" > - " <p><h4>Title suggested</h4>" > - " <ul>" >- - " <li><b>Library:</b> <<branches.branchname>></li>" >- - " <li><b>Title:</b> <<suggestions.title>></li>" >- - " <li><b>Author:</b> <<suggestions.author>></li>" >- - " <li><b>Copyright date:</b> <<suggestions.copyrightdate>></li>" >- - " <li><b>Standard number (ISBN, ISSN or other):</b> <<suggestions.isbn>></li>" >- - " <li><b>Publisher:</b> <<suggestions.publishercode>></li>" >- - " <li><b>Collection title:</b> <<suggestions.collectiontitle>></li>" >- - " <li><b>Publication place:</b> <<suggestions.place>></li>" >- - " <li><b>Quantity:</b> <<suggestions.quantity>></li>" >- - " <li><b>Item type:</b> <<suggestions.itemtype>></li>" >- - " <li><b>Reason for suggestion:</b> <<suggestions.patronreason>></li>" >- - " <li><b>Notes:</b> <<suggestions.note>></li>" >+ - " <li><b>Library:</b> [% branch.branchname %]</li>" >+ - " <li><b>Title:</b> [% suggestion.title %]</li>" >+ - " <li><b>Author:</b> [% suggestion.author %]</li>" >+ - " <li><b>Copyright date:</b> [% suggestion.copyrightdate %]</li>" >+ - " <li><b>Standard number (ISBN, ISSN or other):</b> [% suggestion.isbn %]</li>" >+ - " <li><b>Publisher:</b> [% suggestion.publishercode %]</li>" >+ - " <li><b>Collection title:</b> [% suggestion.collectiontitle %]</li>" >+ - " <li><b>Publication place:</b> [% suggestion.place %]</li>" >+ - " <li><b>Quantity:</b> [% suggestion.quantity %]</li>" >+ - " <li><b>Item type:</b> [% suggestion.itemtype %]</li>" >+ - " <li><b>Reason for suggestion:</b> [% suggestion.patronreason %]</li>" >+ - " <li><b>Notes:</b> [% suggestion.note %]</li>" > - " </ul>" > - " </p>" > >@@ -2039,19 +2043,19 @@ tables: > message_transport_type: email > lang: default > content: >- - "Dear <<borrowers.firstname>> <<borrowers.surname>>," >+ - "Dear [% borrower.firstname %] [% borrower.surname %]," > - "" >- - "You have suggested that the library acquire <<suggestions.title>> by <<suggestions.author>>." >+ - "You have suggested that the library acquire [% suggestion.title %] by [% suggestion.author %]." > - "" > - "We are pleased to inform you that the item you requested has now been ordered. It should arrive soon, at which time it will be processed for addition into the collection." > - "" > - "You will be notified again when the book is available." > - "" >- - "If you have any questions, please email us at <<branches.branchemail>>" >+ - "If you have any questions, please email us at [% branch.branchemail %]" > - "" > - "Thank you," > - "" >- - "<<branches.branchname>>" >+ - "[% branch.branchname %]" > > - module: suggestions > code: REJECTED >@@ -2062,19 +2066,19 @@ tables: > message_transport_type: email > lang: default > content: >- - "Dear <<borrowers.firstname>> <<borrowers.surname>>," >+ - "Dear [% borrower.firstname %] [% borrower.surname %]," > - "" >- - "You have suggested that the library acquire <<suggestions.title>> by <<suggestions.author>>." >+ - "You have suggested that the library acquire [% suggestion.title %] by [% suggestion.author %]." > - "" > - "The library has reviewed your request today, and has decided not to accept the suggestion at this time." > - "" >- - "The reason given is: <<suggestions.reason>>" >+ - "The reason given is: [% suggestion.reason %]" > - "" >- - "If you have any questions, please email us at <<branches.branchemail>>." >+ - "If you have any questions, please email us at [% branch.branchemail %]." > - "" > - "Thank you," > - "" >- - "<<branches.branchname>>" >+ - "[% branch.branchname %]" > > - module: suggestions > code: TO_PROCESS >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35925
:
164951
|
166416