The following notices relating to purchase suggestions all need to be updated to use Template Toolkit syntax: ACCEPTED AVAILABLE NEW_SUGGESTION ORDERED REJECTED TO_PROCESS Most of these messages are very similar and access the same data, so it makes sense to do them all together.
Splitting this into two bugs based on workflow, for simplicity of testing.
Created attachment 164951 [details] [review] Bug 35925: Adjust default purchase suggestion notices to use TT 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set syspref EmailPurchaseSuggestions to "email address of library" 4. Under Administration > Libraries, enter an email address for at least one library 5. Go to "my account", and enter a Primary email and Phone number 6. Go to the Acquisitions module > Suggestions page 7. Click "New purchase suggestion", and fill in values for, at minimum: Bibliographic information: Title Author Copyright date ISBN/ISSN Publisher Publication place Collection title Document type Reason for suggestion Notes Acquisition information: Library (set to the library you entered an email for in step 4) Copies 8. Submit the suggestion 9. Set the suggestion status to "Rejected" a. Check the checkbox next to the suggestion b. Set the "Mark selected as" drop-down (below the table) to Rejected c. Select a value for the "Reason" drop-down d. Click the Submit button 10. Set the suggestion status to "Accepted" (as above) 11. Set the suggestion status to "Ordered" (as above) 12. Return to "my account" and open the Notices tab --> There should be notices suggestion declined, suggestion accepted, suggestion ordered, and (depending on settings) new suggestion* 13. Open each notice, and confirm the all information was filled in correctly * New suggestion will be there if you're using default KTD settings/data and logged in as the root user. If it is not there, query the database (by command line or SQL report) to see the generated notice text: SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION'