Bug 35925 - Port default NEW_SUGGESTION, REJECTED, ACCEPTED, and ORDERED notices to Template Toolkit
Summary: Port default NEW_SUGGESTION, REJECTED, ACCEPTED, and ORDERED notices to Templ...
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Emily Lamancusa (emlam)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: Academy, roadmap_24_05
Depends on:
Blocks: 15278
  Show dependency tree / graph
 
Reported: 2024-01-26 19:54 UTC by Emily Lamancusa (emlam)
Modified: 2024-11-08 14:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
The default notice templates for suggestion notifications (NEW_SUGGESTION, REJECTED, ACCEPTED, and ORDERED) now use modern Template Toolkit rather than the old custom syntax. This will only affect new installations, unless the library chooses to reset their notices to the default.
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 35925: Adjust default purchase suggestion notices to use TT (8.52 KB, patch)
2024-04-16 14:44 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Bug 35925: Adjust default purchase suggestion notices to use TT (8.59 KB, patch)
2024-05-08 13:21 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-01-26 19:54:55 UTC 
The following notices relating to purchase suggestions all need to be updated to use Template Toolkit syntax:
ACCEPTED
AVAILABLE
NEW_SUGGESTION
ORDERED
REJECTED
TO_PROCESS

Most of these messages are very similar and access the same data, so it makes sense to do them all together.
Comment 1 Emily Lamancusa (emlam) 2024-04-16 13:50:44 UTC 
Splitting this into two bugs based on workflow, for simplicity of testing.
Comment 2 Emily Lamancusa (emlam) 2024-04-16 14:44:43 UTC 
Created attachment 164951 [details] [review]
Bug 35925: Adjust default purchase suggestion notices to use TT

1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Set syspref EmailPurchaseSuggestions to "email address of library"
4. Under Administration > Libraries, enter an email address for at least
   one library
5. Go to "my account", and enter a Primary email and Phone number
6. Go to the Acquisitions module > Suggestions page
7. Click "New purchase suggestion", and fill in values for, at minimum:
    Bibliographic information:
        Title
        Author
        Copyright date
        ISBN/ISSN
        Publisher
        Publication place
        Collection title
        Document type
        Reason for suggestion
        Notes
    Acquisition information:
        Library (set to the library you entered an email for in step 4)
        Copies
8. Submit the suggestion
9. Set the suggestion status to "Rejected"
    a. Check the checkbox next to the suggestion
    b. Set the "Mark selected as" drop-down (below the table) to Rejected
    c. Select a value for the "Reason" drop-down
    d. Click the Submit button
10. Set the suggestion status to "Accepted" (as above)
11. Set the suggestion status to "Ordered" (as above)
12. Return to "my account" and open the Notices tab
--> There should be notices suggestion declined, suggestion accepted,
    suggestion ordered, and (depending on settings) new suggestion*
13. Open each notice, and confirm the all information was filled in
    correctly

* New suggestion will be there if you're using default KTD settings/data
and logged in as the root user. If it is not there, query the database
(by command line or SQL report) to see the generated notice text:
SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION'
Comment 3 Martin Renvoize (ashimema) 2024-05-08 13:21:52 UTC 
Created attachment 166416 [details] [review]
Bug 35925: Adjust default purchase suggestion notices to use TT

1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Set syspref EmailPurchaseSuggestions to "email address of library"
4. Under Administration > Libraries, enter an email address for at least
   one library
5. Go to "my account", and enter a Primary email and Phone number
6. Go to the Acquisitions module > Suggestions page
7. Click "New purchase suggestion", and fill in values for, at minimum:
    Bibliographic information:
        Title
        Author
        Copyright date
        ISBN/ISSN
        Publisher
        Publication place
        Collection title
        Document type
        Reason for suggestion
        Notes
    Acquisition information:
        Library (set to the library you entered an email for in step 4)
        Copies
8. Submit the suggestion
9. Set the suggestion status to "Rejected"
    a. Check the checkbox next to the suggestion
    b. Set the "Mark selected as" drop-down (below the table) to Rejected
    c. Select a value for the "Reason" drop-down
    d. Click the Submit button
10. Set the suggestion status to "Accepted" (as above)
11. Set the suggestion status to "Ordered" (as above)
12. Return to "my account" and open the Notices tab
--> There should be notices suggestion declined, suggestion accepted,
    suggestion ordered, and (depending on settings) new suggestion*
13. Open each notice, and confirm the all information was filled in
    correctly

* New suggestion will be there if you're using default KTD settings/data
and logged in as the root user. If it is not there, query the database
(by command line or SQL report) to see the generated notice text:
SELECT * FROM message_queue WHERE letter_code = 'NEW_SUGGESTION'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-05-08 13:22:09 UTC 
More great work, Passing QA, Thankyou!
Comment 5 Katrin Fischer 2024-05-10 13:19:59 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-29 08:47:40 UTC 
Not backported to 23.11.x