Bugzilla – Attachment 164986 Details for
Bug 34963
Unable to delete fields in suggestions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34963: Restore the ability to blank fields when editing a suggestion
Bug-34963-Restore-the-ability-to-blank-fields-when.patch (text/plain), 1.45 KB, created by
Jonathan Druart
on 2024-04-17 09:51:16 UTC
(
hide
)
Description:
Bug 34963: Restore the ability to blank fields when editing a suggestion
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-04-17 09:51:16 UTC
Size:
1.45 KB
patch
obsolete
>From 3e1c8f79ce543719444265fd5c9fd43110b692a7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Apr 2024 11:48:16 +0200 >Subject: [PATCH] Bug 34963: Restore the ability to blank fields when editing a > suggestion > >Regression introduced by bug 23991. >We don't want to remove the fields from the edition if they are empty. > >Ideally we should have separate parameters for edition and search, but >this is the low-effort fix, and hopefully won't introduce side-effects. > >Test plan: >Try to edit a suggestion and blank some fields >Try to search for suggestions using the search form on the left of the >screen >--- > suggestion/suggestion.pl | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index fa462bbf8af..4ee69957f03 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -117,8 +117,11 @@ foreach (keys %$suggestion_ref){ > } > delete $suggestion_only->{branchcode} if $suggestion_only->{branchcode} eq '__ANY__'; > delete $suggestion_only->{budgetid} if $suggestion_only->{budgetid} eq '__ANY__'; >-while ( my ( $k, $v ) = each %$suggestion_only ) { >- delete $suggestion_only->{$k} if $v eq ''; >+ >+unless ( $op eq 'cud-save' ) { >+ while ( my ( $k, $v ) = each %$suggestion_only ) { >+ delete $suggestion_only->{$k} if $v eq ''; >+ } > } > > my ( $template, $borrowernumber, $cookie, $userflags ) = get_template_and_user( >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34963
:
164986
|
165020
|
165200