It doesn't appear possible to delete a note in a suggestion, although it is possible to edit it. To reproduce, create a suggestion record and add a note and non-public note. Edit the suggestion and change the contents of your notes, and save. The notes will both correctly update to your new note text. Now edit the suggestion again and this time completely delete the note. The data does not get deleted.
I noticed this is happening as well. It happens for the Note and Non-Public Note field in a suggestion. Our current version: 22.11.09.000 Rosalie
I can replicate this on current master.
Actually it's all the non-mandatory fields - you can't empty them, only edit.
I just noticed this is also true for the new non-public note...
It's all the text fields :( But I haven't been able to get developer's attention on this bug.
Created attachment 164986 [details] [review] Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen
Sorry, I was not aware of this bug (or I forgot!)
Created attachment 165020 [details] [review] Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Added 2 suggestions, one via Intranet, one via OPAC. Added content to publisher, public and private notes fields. Prior to patch application could not delete any of the three. After the patch applied could delete all three fields in both OPAC and Intranet sourced suggestions. (I did restart services- not sure if that was necessary- am new to signoffs).
It never hurts to restart the services :) Thanks for the fix and sign-off!
Created attachment 165200 [details] [review] Bug 34963: Restore the ability to blank fields when editing a suggestion Regression introduced by bug 23991. We don't want to remove the fields from the edition if they are empty. Ideally we should have separate parameters for edition and search, but this is the low-effort fix, and hopefully won't introduce side-effects. Test plan: Try to edit a suggestion and blank some fields Try to search for suggestions using the search form on the left of the screen Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06 Patch adapted : 'cud-save' => 'save'
Backported to 23.05.x for upcoming 23.05.12