Bugzilla – Attachment 165521 Details for
Bug 29393
Ability to send emails from patron details page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29393: (QA follow-up) Tidy and make executable the new test
Bug-29393-QA-follow-up-Tidy-and-make-executable-th.patch (text/plain), 2.41 KB, created by
Martin Renvoize (ashimema)
on 2024-04-25 11:01:35 UTC
(
hide
)
Description:
Bug 29393: (QA follow-up) Tidy and make executable the new test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-04-25 11:01:35 UTC
Size:
2.41 KB
patch
obsolete
>From f89a07709a49c1a1654678afb7e482a039804b1f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 25 Apr 2024 10:01:25 +0100 >Subject: [PATCH] Bug 29393: (QA follow-up) Tidy and make executable the new > test > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../Template/Plugin/NoticeTemplates.t | 52 +++++++++++-------- > 1 file changed, 29 insertions(+), 23 deletions(-) > mode change 100644 => 100755 t/db_dependent/Template/Plugin/NoticeTemplates.t > >diff --git a/t/db_dependent/Template/Plugin/NoticeTemplates.t b/t/db_dependent/Template/Plugin/NoticeTemplates.t >old mode 100644 >new mode 100755 >index 84e38578d6a..2f26e820763 >--- a/t/db_dependent/Template/Plugin/NoticeTemplates.t >+++ b/t/db_dependent/Template/Plugin/NoticeTemplates.t >@@ -27,40 +27,46 @@ BEGIN { > use_ok('Koha::Template::Plugin::NoticeTemplates'); > } > >-my $schema = Koha::Database->new->schema; >+my $schema = Koha::Database->new->schema; > my $builder = t::lib::TestBuilder->new; > $schema->storage->txn_begin; > > Koha::Notice::Templates->delete(); > >-my $notice_templates = Koha::Notice::Templates->search({ module => 'members'}); >+my $notice_templates = Koha::Notice::Templates->search( { module => 'members' } ); > >-$builder->build({ >- source => 'Letter', >- value => { >- name => 'Hold cancellation', >- module => 'reserves' >+$builder->build( >+ { >+ source => 'Letter', >+ value => { >+ name => 'Hold cancellation', >+ module => 'reserves' >+ } > } >-}); >- >-$builder->build({ >- source => 'Letter', >- value => { >- name => 'Account expiration', >- module => 'members' >+); >+ >+$builder->build( >+ { >+ source => 'Letter', >+ value => { >+ name => 'Account expiration', >+ module => 'members' >+ } > } >-}); >- >-$builder->build({ >- source => 'Letter', >- value => { >- name => 'Discharge', >- module => 'members' >+); >+ >+$builder->build( >+ { >+ source => 'Letter', >+ value => { >+ name => 'Discharge', >+ module => 'members' >+ } > } >-}); >+); > > my $plugin = Koha::Template::Plugin::NoticeTemplates->new(); >-ok($plugin, "initialized notice templates plugin"); >+ok( $plugin, "initialized notice templates plugin" ); > > my $notices = $plugin->GetByModule('members'); > is( $notices->count, 2, 'returns 2 defined members letters' ); >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29393
:
127237
|
127238
|
127452
|
127506
|
127511
|
127847
|
128215
|
128216
|
128217
|
128218
|
128219
|
128363
|
148187
|
148188
|
148189
|
148190
|
148191
|
148192
|
148193
|
148194
|
149812
|
160107
|
160108
|
160109
|
160110
|
160111
|
160112
|
160113
|
160114
|
160633
|
160638
|
160639
|
165498
|
165499
|
165500
|
165501
|
165502
|
165503
|
165504
|
165505
|
165511
|
165512
|
165513
|
165514
|
165515
|
165516
|
165517
|
165518
|
165519
|
165520
| 165521 |
165522
|
165942