Created attachment 127237 [details] [review] Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message
Created attachment 127238 [details] [review] Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table
This adds the ability to send email via patron messages (/cgi-bin/koha/circ/add_message.pl). This feature depends on bug 12802. Recipients are defined by AutoEmailPrimaryAddress.
I worry that too many of the available notices depend on logic or circumstances which aren't taken into account for here. - ACCTDETAILS Account Details Template - DEFAULT -- This one is useful, although it's not good that our sample notice includes the encrypted password. - MEMBERSHIP_EXPIRY Account expiration -- I can see this being useful as well. - OPAC_REG_VERIFY Opac Self-Registration Verification Email -- This would be useful if it could be done, but can it? If you require email verification for self-registrations the patron record isn't created until verified. Meaning you couldn't find the patron record to re-send the verification. - PASSWORD_RESET Online password reset -- Useful, but doesn't work. There is no link in the message. - DISCHARGE Discharge -- This notice is usually generated as a PDF, not sent via email. Does an email work for the discharge process? These notices don't make sense because there's not enough context for the message: PROBLEM_REPORT OPAC Problem Report SHARE_ACCEPT Notification about an accepted share SHARE_INVITE Invitation for sharing a list
I feel this would benefit from having a permission attached to it. Many libraries will not want all staff to have this ability and will want an easy way to disable it, without blocking staff from being able to use the Add message functionality.
(In reply to Owen Leonard from comment #4) > I worry that too many of the available notices depend on logic or > circumstances which aren't taken into account for here. > Hello Owen, I would say that it is the responsibility of the user/librarian to use the appropriate letter. Is there any security/system/GDPR risk according to you ? The goal here is to allow librarian to have some predefined letters to be used in the "Add message" feature. I choose "members" as letters category for this. Would a new module be better ? And thank you for testing.
Created attachment 127452 [details] [review] Bug 29393 - Use patron language in letters
Created attachment 127506 [details] [review] Bug 29393 - add a dedicated letters module for add message
Created attachment 127511 [details] [review] Bug 29393 - Add send_messages_to_borrowers permission
Created attachment 127847 [details] [review] Bug 29393 - Don't show notice templates for each language
Created attachment 128215 [details] [review] Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table Sponsored-by: Aix-Marseille University
Created attachment 128216 [details] [review] Bug 29393 - Use patron language in letters Sponsored-by: Aix-Marseille University
Created attachment 128217 [details] [review] Bug 29393 - add a dedicated letters module for add message Sponsored-by: Aix-Marseille University
Created attachment 128218 [details] [review] Bug 29393 - Add send_messages_to_borrowers permission Sponsored-by: Aix-Marseille University
Created attachment 128219 [details] [review] Bug 29393 - Don't show notice templates for each language Sponsored-by: Aix-Marseille University
Created attachment 128363 [details] [review] Bug 29393 - Sort notice templates by name Sponsored-by: Aix-Marseille University
patch doesn't apply
Created attachment 148187 [details] [review] Bug 29393: (follow-up) Explicite use of methods from C4
Created attachment 148188 [details] [review] Bug 29393: Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table
Created attachment 148189 [details] [review] Bug 29393: Use patron language in letters
Created attachment 148190 [details] [review] Bug 29393: Add a dedicated letters module for add message
Created attachment 148191 [details] [review] Bug 29393: Add send_messages_to_borrowers permission
Created attachment 148192 [details] [review] Bug 29393: Don't show notice templates for each language
Created attachment 148193 [details] [review] Bug 29393: Sort notice templates by name
Created attachment 148194 [details] [review] Bug 29393: (follow-up) Explicite use of methods from C4
rebased on current master + a small follow-up
Created attachment 149812 [details] [review] Bug 29393: Prevent SQL errors when SQL strict mode is set
Merge conflicts in circ/add_message.pl.
Created attachment 160107 [details] [review] Bug 29393: Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table
Created attachment 160108 [details] [review] Bug 29393: Use patron language in letters
Created attachment 160109 [details] [review] Bug 29393: Add a dedicated letters module for add message
Created attachment 160110 [details] [review] Bug 29393: Add send_messages_to_borrowers permission
Created attachment 160111 [details] [review] Bug 29393: Don't show notice templates for each language
Created attachment 160112 [details] [review] Bug 29393: Sort notice templates by name
Created attachment 160113 [details] [review] Bug 29393: (follow-up) Explicite use of methods from C4
Created attachment 160114 [details] [review] Bug 29393: Prevent SQL errors when SQL strict mode is set
Just a rebase for now.. Reviewing the code a bit next.
I'm interested in the idea's here.. but I'd love to see a specification or set or original requirements attached. I fear we're ending up with a series of overlapping features.. we need someone to take a step back and look at the big picture. We now have 'OPAC Problem reports', 'Catalog concerns (misnamed due to original requirements.. should really be 'request tracking'), Notices, 'OPAC Note' and checkout notes.
I feel like we could improve the notice template functionality, displaying a preview (maybe even editable) of the notice prior to sending.
Some notes: - If you add a new notice to Patrons (MEMBERS) category, they do not show up in Add message email drop down. Test plan does not apply in this case. - If you add a new notice to "Add message" category, they show up in Add message email drop down. There is no mention of this category in the test plan. - When you choose a notice to send, you cannot see it's content. You can see it only after it is saved to message queue.
Created attachment 160633 [details] [review] Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: matthias <matthias.le-gac@inlibro.net>
Created attachment 160638 [details] [review] Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: matthias <matthias.le-gac@inlibro.net>
Created attachment 160639 [details] [review] Bug 29393: Prevent SQL errors when SQL strict mode is set Signed-off-by: Phan Tung Bui <phan-tung.bui@inlibro.com>