Bugzilla – Attachment 165746 Details for
Bug 35993
AddBiblio should add 005 just like ModBiblio updates it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35993: (follow-up) Fix Merge.t
Bug-35993-follow-up-Fix-Merget.patch (text/plain), 1.50 KB, created by
Marcel de Rooy
on 2024-04-29 14:17:25 UTC
(
hide
)
Description:
Bug 35993: (follow-up) Fix Merge.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-04-29 14:17:25 UTC
Size:
1.50 KB
patch
obsolete
>From b473281729b2af789bd88ee053f3506591df617a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 29 Apr 2024 14:14:20 +0000 >Subject: [PATCH] Bug 35993: (follow-up) Fix Merge.t >Content-Type: text/plain; charset=utf-8 > >The change for 005 makes some field compares fail. We should >exclude 005 in the local compare_fields sub. > >We do NOT need the compare_fields from AuthoritiesMarc. Removing. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Authority/Merge.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Authority/Merge.t b/t/db_dependent/Authority/Merge.t >index 0fd332ab4d..cfb5fd26fe 100755 >--- a/t/db_dependent/Authority/Merge.t >+++ b/t/db_dependent/Authority/Merge.t >@@ -22,7 +22,7 @@ use Koha::Biblios; > use Koha::Database; > > BEGIN { >- use_ok('C4::AuthoritiesMarc', qw( merge AddAuthority compare_fields DelAuthority ModAuthority )); >+ use_ok('C4::AuthoritiesMarc', qw( merge AddAuthority DelAuthority ModAuthority )); > } > > # Optionally change marc flavour >@@ -636,6 +636,8 @@ sub compare_fields { # mode parameter: order or count > # By default exclude field 100 from comparison in UNIMARC. > # Will have been added by ModBiblio in merge. > $exclude->{100} = 1; >+ } else { #MARC21 >+ $exclude->{'005'} = 1; > } > my @oldfields = map { $exclude->{$_->tag} ? () : $_->tag } $oldmarc->fields; > my @newfields = map { $exclude->{$_->tag} ? () : $_->tag } $newmarc->fields; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35993
:
161761
|
161762
|
161776
|
161777
|
161778
|
161805
|
161992
|
161993
|
161994
|
161995
|
165271
|
165272
|
165370
|
165371
| 165746 |
165748
|
166063