Bug 35993 - AddBiblio should add 005 just like ModBiblio updates it
Summary: AddBiblio should add 005 just like ModBiblio updates it
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-05 13:09 UTC by Marcel de Rooy
Modified: 2024-04-23 10:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.69 KB, patch)
2024-02-05 14:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (3.24 KB, patch)
2024-02-05 14:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.72 KB, patch)
2024-02-06 13:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (3.33 KB, patch)
2024-02-06 13:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (3.41 KB, patch)
2024-02-06 13:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (2.72 KB, patch)
2024-02-07 14:14 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.73 KB, patch)
2024-02-09 18:25 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (2.73 KB, patch)
2024-02-09 18:25 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.79 KB, patch)
2024-02-09 18:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (2.78 KB, patch)
2024-02-09 18:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.83 KB, patch)
2024-04-22 11:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (2.83 KB, patch)
2024-04-22 11:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35993: Add SimpleMarc::update_last_transaction_time (3.85 KB, patch)
2024-04-23 10:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35993: Apply new routine to ModBiblioMarc (2.85 KB, patch)
2024-04-23 10:23 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-02-05 13:09:11 UTC
Records added via Acquisition do not contain a 005 tag. This is inconsistent.
Comment 1 Marcel de Rooy 2024-02-05 14:16:04 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2024-02-05 14:16:06 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2024-02-06 13:16:03 UTC
Created attachment 161776 [details] [review]
Bug 35993: Add SimpleMarc::update_last_transaction_time

Note: This routine does not check field existence like
ModBiblioMarc does/did (see next patch). So it inserts
a field 005 if it is not present.

Test plan:
Run t/SimpleMARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2024-02-06 13:16:05 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2024-02-06 13:19:57 UTC
Created attachment 161778 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2024-02-07 14:14:05 UTC
Created attachment 161805 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Phil Ringnalda 2024-02-09 18:25:27 UTC
Created attachment 161992 [details] [review]
Bug 35993: Add SimpleMarc::update_last_transaction_time

Note: This routine does not check field existence like
ModBiblioMarc does/did (see next patch). So it inserts
a field 005 if it is not present.

Test plan:
Run t/SimpleMARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 8 Phil Ringnalda 2024-02-09 18:25:30 UTC
Created attachment 161993 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 9 Lucas Gass 2024-02-09 18:31:50 UTC
Created attachment 161994 [details] [review]
Bug 35993: Add SimpleMarc::update_last_transaction_time

Note: This routine does not check field existence like
ModBiblioMarc does/did (see next patch). So it inserts
a field 005 if it is not present.

Test plan:
Run t/SimpleMARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 10 Lucas Gass 2024-02-09 18:31:52 UTC
Created attachment 161995 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 11 Marcel de Rooy 2024-02-12 06:39:09 UTC
> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Thx Phil and Lucas !
Comment 12 Marcel de Rooy 2024-04-22 11:43:57 UTC
Created attachment 165271 [details] [review]
Bug 35993: Add SimpleMarc::update_last_transaction_time

Note: This routine does not check field existence like
ModBiblioMarc does/did (see next patch). So it inserts
a field 005 if it is not present.

Test plan:
Run t/SimpleMARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 13 Marcel de Rooy 2024-04-22 11:43:59 UTC
Created attachment 165272 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 14 Marcel de Rooy 2024-04-22 11:44:22 UTC
Rebased (Biblio.t)
Comment 15 Martin Renvoize 2024-04-23 10:23:52 UTC
Created attachment 165370 [details] [review]
Bug 35993: Add SimpleMarc::update_last_transaction_time

Note: This routine does not check field existence like
ModBiblioMarc does/did (see next patch). So it inserts
a field 005 if it is not present.

Test plan:
Run t/SimpleMARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 16 Martin Renvoize 2024-04-23 10:23:55 UTC
Created attachment 165371 [details] [review]
Bug 35993: Apply new routine to ModBiblioMarc

Now both AddBiblio and ModBiblio will insert 005 if not present.

Test plan:
Run t/db_dependent/Biblio.t
Add biblio record via acquistion order. Check 005 in the table
biblio_metadata.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 17 Martin Renvoize 2024-04-23 10:24:18 UTC
Clean code, well tested, works as described.

Passing QA