Bugzilla – Attachment 166063 Details for
Bug 35993
AddBiblio should add 005 just like ModBiblio updates it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35993: (follow-up) Another fix for MarcOverlayRules.t
Bug-35993-follow-up-Another-fix-for-MarcOverlayRul.patch (text/plain), 2.04 KB, created by
Marcel de Rooy
on 2024-05-02 11:44:14 UTC
(
hide
)
Description:
Bug 35993: (follow-up) Another fix for MarcOverlayRules.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-05-02 11:44:14 UTC
Size:
2.04 KB
patch
obsolete
>From 03cc3e41fa3c5caa247648d48b15d3ed53a547bb Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 2 May 2024 11:42:41 +0000 >Subject: [PATCH] Bug 35993: (follow-up) Another fix for MarcOverlayRules.t >Content-Type: text/plain; charset=utf-8 > >We should not assume comparing within the same second. Now just >remove 005 before comparing. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Biblio/MarcOverlayRules.t | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Biblio/MarcOverlayRules.t b/t/db_dependent/Biblio/MarcOverlayRules.t >index 2e0b1990c6..9ba27a93b9 100755 >--- a/t/db_dependent/Biblio/MarcOverlayRules.t >+++ b/t/db_dependent/Biblio/MarcOverlayRules.t >@@ -769,9 +769,9 @@ subtest 'context option in ModBiblio is handled correctly' => sub { > [ '500', 'a', 'One bottle of beer in the fridge' ], # original > [ '999', 'c', $biblionumber, 'd', $biblioitemnumber ], # created by AddBiblio > ]); >- $expected_record->insert_fields_ordered( >- MARC::Field->new( '005', $saved_record->field('005')->data ), >- ); # simulate same timestamp >+ >+ # Remove timestamp from saved record when comparing >+ $saved_record->delete_fields( $saved_record->field('005') ); > > # Make sure leader is equal after AddBiblio > $expected_record->leader($saved_record->leader()); >@@ -798,9 +798,9 @@ subtest 'context option in ModBiblio is handled correctly' => sub { > [ '500', 'a', 'One cold bottle of beer in the fridge' ], > [ '999', 'c', $biblionumber, 'd', $biblioitemnumber ], # created by AddBiblio > ]); >- $expected_record->insert_fields_ordered( >- MARC::Field->new( '005', $saved_record->field('005')->data ), >- ); # simulate same timestamp >+ >+ # Remove timestamp from saved record when comparing >+ $updated_record->delete_fields( $updated_record->field('005') ); > > # Make sure leader is equal after ModBiblio > $expected_record->leader($updated_record->leader()); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35993
:
161761
|
161762
|
161776
|
161777
|
161778
|
161805
|
161992
|
161993
|
161994
|
161995
|
165271
|
165272
|
165370
|
165371
|
165746
|
165748
| 166063