Bugzilla – Attachment 166238 Details for
Bug 36796
Fix mistake in database column descriptions for statistics table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36796: (follow-up) Fix column descriptions for the statistics table
Bug-36796-follow-up-Fix-column-descriptions-for-th.patch (text/plain), 4.35 KB, created by
David Nind
on 2024-05-07 05:46:21 UTC
(
hide
)
Description:
Bug 36796: (follow-up) Fix column descriptions for the statistics table
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-07 05:46:21 UTC
Size:
4.35 KB
patch
obsolete
>From ce8e175adbe2338f7df5cb9302f1a9a1442e24e7 Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Tue, 7 May 2024 05:41:54 +0000 >Subject: [PATCH] Bug 36796: (follow-up) Fix column descriptions for the > statistics table > >This follow-up to bug 32312 fixes the descriptions for the statistics >database columns, used in guided reports. > >It removes the duplicate statistics section in Koha/Database/Columns.pm >so that descriptions are displayed for all columns, as originally >intended. > >It also adds a description for the interface column (a new column added >after the original patch was pushed). > >Test plan: >1. Go to Reports > Guided reports > Create guided report. >2. Choose 'Circulation' for the module to report on and select > 'Next'. >3. Choose 'Tabular' for the type of report and select 'Next'. >4. Scroll down to the statistics table section and note that some > columns have descriptions and some don't: > Statistics date and time / statistics.datetime > Library / statistics.branch > Value / statistics.value > Type / statistics.type > Item number / statistics.itemnumber > Item type / statistics.itemtype > statistics.other > statistics.location > Borrower number / statistics.borrowernumber > statistics.ccode > statistics.categorycode > statistics.interface >5. Apply the patch. >6. Restart all the things (restart_all). >7. Repeat steps 1 to 4. >8. Scroll down to the statistics table section again and note that all > columns now have descriptions: > Statistics date and time / statistics.datetime > Library / statistics.branch > Value / statistics.value > Transaction type / statistics.type > SIP mode / statistics.other > Item number / statistics.itemnumber > Koha item type / statistics.itemtype > Shelving location / statistics.location > Borrower number / statistics.borrowernumber > Collection / statistics.ccode > Patron category / statistics.categorycode > Interface / statistics.interface >9. Sign off :D > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Database/Columns.pm | 29 ++++++++++------------------- > 1 file changed, 10 insertions(+), 19 deletions(-) > >diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm >index 1742a09cf0..a7fb1a5e47 100644 >--- a/Koha/Database/Columns.pm >+++ b/Koha/Database/Columns.pm >@@ -242,19 +242,6 @@ sub columns { > "new_status" => __("New status"), > "exclude_from_local_holds_priority" => __("Exclude from local holds priority"), > }, >- statistics => { >- "datetime" => __("Statistics date and time"), >- "branch" => __("Library"), >- "value" => __("Value"), >- "type" => __("Transaction type"), >- "other" => __("SIP mode"), >- "itemnumber" => __("Item number"), >- "itemtype" => __("Koha item type"), >- "location" => __("Shelving location"), >- "borrowernumber" => __("Borrower number"), >- "ccode" => __("Collection"), >- "categorycode" => __("Patron category"), >- }, > biblio => { > "abstract" => __("Abstract"), > "author" => __("Author"), >@@ -300,14 +287,18 @@ sub columns { > "volumedesc" => __("Volume information"), > }, > statistics => { >- "borrowernumber" => __("Borrower number"), >- "branch" => __("Library"), > "datetime" => __("Statistics date and time"), >- "itemnumber" => __("Item number"), >- "itemtype" => __("Itemtype"), >- "other" => __(""), >- "type" => __("Type"), >+ "branch" => __("Library"), > "value" => __("Value"), >+ "type" => __("Transaction type"), >+ "other" => __("SIP mode"), >+ "itemnumber" => __("Item number"), >+ "itemtype" => __("Koha item type"), >+ "location" => __("Shelving location"), >+ "borrowernumber" => __("Borrower number"), >+ "ccode" => __("Collection"), >+ "categorycode" => __("Patron category"), >+ "interface" => __("Interface"), > }, > subscription => { > "branchcode" => __("Library"), >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36796
:
166238
|
166279