Bug 36796 - Fix mistake in database column descriptions for statistics table
Summary: Fix mistake in database column descriptions for statistics table
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate, rel_23_05_candidate
Depends on: 32312
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-06 14:41 UTC by Katrin Fischer
Modified: 2024-12-05 17:46 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the descriptions for the statistics database columns, used in guided reports, (it is a follow-up to bug 32312): - The descriptions for the statistics section columns now display as intended. - It adds a description for the interface column (a new column added after the original bug).
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36796: (follow-up) Fix column descriptions for the statistics table (4.35 KB, patch)
2024-05-07 05:46 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36796: (follow-up) Fix column descriptions for the statistics table (4.43 KB, patch)
2024-05-07 12:58 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-05-06 14:41:27 UTC 
from bug 32312:

(In reply to Jonathan Druart from comment #12)
> Something wrong here, statistics was present already.
> 
> 245         statistics => {
> 246             "datetime"       => __("Statistics date and time"),
> 247             "branch"         => __("Library"),
> 248             "value"          => __("Value"),
> 249             "type"           => __("Transaction type"),
> 250             "other"          => __("SIP mode"),
> 251             "itemnumber"     => __("Item number"),
> 252             "itemtype"       => __("Koha item type"),
> 253             "location"       => __("Shelving location"),
> 254             "borrowernumber" => __("Borrower number"),
> 255             "ccode"          => __("Collection"),
> 256             "categorycode"   => __("Patron category"),
> 257         },
> 
> 302         statistics => {
> 303             "borrowernumber" => __("Borrower number"),
> 304             "branch"         => __("Library"),
> 305             "datetime"       => __("Statistics date and time"),
> 306             "itemnumber"     => __("Item number"),
> 307             "itemtype"       => __("Itemtype"),
> 308             "other"          => __(""),
> 309             "type"           => __("Type"),
> 310             "value"          => __("Value"),
> 311         },
> 
> In this second block "other" is getting __("") which leads to displaying the
> header of the po file when using a translated interface.
Comment 1 David Nind 2024-05-07 05:46:21 UTC 
Created attachment 166238 [details] [review]
Bug 36796: (follow-up) Fix column descriptions for the statistics table

This follow-up to bug 32312 fixes the descriptions for the statistics
database columns, used in guided reports.

It removes the duplicate statistics section in Koha/Database/Columns.pm
so that descriptions are displayed for all columns, as originally
intended.

It also adds a description for the interface column (a new column added
after the original patch was pushed).

Test plan:
1. Go to Reports > Guided reports > Create guided report.
2. Choose 'Circulation' for the module to report on and select
   'Next'.
3. Choose 'Tabular' for the type of report and select 'Next'.
4. Scroll down to the statistics table section and note that some
   columns have descriptions and some don't:
     Statistics date and time / statistics.datetime
     Library / statistics.branch
     Value / statistics.value
     Type / statistics.type
     Item number / statistics.itemnumber
     Item type / statistics.itemtype
     statistics.other
     statistics.location
     Borrower number / statistics.borrowernumber
     statistics.ccode
     statistics.categorycode
     statistics.interface
5. Apply the patch.
6. Restart all the things (restart_all).
7. Repeat steps 1 to 4.
8. Scroll down to the statistics table section again and note that all
   columns now have descriptions:
     Statistics date and time / statistics.datetime
     Library / statistics.branch
     Value / statistics.value
     Transaction type / statistics.type
     SIP mode / statistics.other
     Item number / statistics.itemnumber
     Koha item type / statistics.itemtype
     Shelving location / statistics.location
     Borrower number / statistics.borrowernumber
     Collection / statistics.ccode
     Patron category / statistics.categorycode
     Interface / statistics.interface
9. Sign off :D

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Jonathan Druart 2024-05-07 12:58:18 UTC 
Created attachment 166279 [details] [review]
Bug 36796: (follow-up) Fix column descriptions for the statistics table

This follow-up to bug 32312 fixes the descriptions for the statistics
database columns, used in guided reports.

It removes the duplicate statistics section in Koha/Database/Columns.pm
so that descriptions are displayed for all columns, as originally
intended.

It also adds a description for the interface column (a new column added
after the original patch was pushed).

Test plan:
1. Go to Reports > Guided reports > Create guided report.
2. Choose 'Circulation' for the module to report on and select
   'Next'.
3. Choose 'Tabular' for the type of report and select 'Next'.
4. Scroll down to the statistics table section and note that some
   columns have descriptions and some don't:
     Statistics date and time / statistics.datetime
     Library / statistics.branch
     Value / statistics.value
     Type / statistics.type
     Item number / statistics.itemnumber
     Item type / statistics.itemtype
     statistics.other
     statistics.location
     Borrower number / statistics.borrowernumber
     statistics.ccode
     statistics.categorycode
     statistics.interface
5. Apply the patch.
6. Restart all the things (restart_all).
7. Repeat steps 1 to 4.
8. Scroll down to the statistics table section again and note that all
   columns now have descriptions:
     Statistics date and time / statistics.datetime
     Library / statistics.branch
     Value / statistics.value
     Transaction type / statistics.type
     SIP mode / statistics.other
     Item number / statistics.itemnumber
     Koha item type / statistics.itemtype
     Shelving location / statistics.location
     Borrower number / statistics.borrowernumber
     Collection / statistics.ccode
     Patron category / statistics.categorycode
     Interface / statistics.interface
9. Sign off :D

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Katrin Fischer 2024-05-07 15:41:58 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 4 Fridolin Somers 2024-05-24 14:46:04 UTC 
Pushed to 23.11.x for 23.11.06