Attachment 166514 Details for Bug 33737 – Bug 33737: Fix patron bookings table display issues

[patch] Bug 33737: Fix patron bookings table display issues

Bug-33737-Fix-patron-bookings-table-display-issues.patch (text/plain), 3.69 KB, created by Marcel de Rooy on 2024-05-10 09:18:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-05-10 09:18:48 UTC

Size: 3.69 KB

patch

obsolete

>From cd5ae5cc915d70fe6b9c3dee5d49e4e627ee7312 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 18 Aug 2023 11:21:37 +0100
>Subject: [PATCH] Bug 33737: Fix patron bookings table display issues
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Esther Melander <esther@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/includes/patron-detail-tabs.inc          |  2 +-
> .../prog/en/modules/members/moremember.tt            | 12 +++++-------
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
>index 17f68d2ae0..b220d7952a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc
>@@ -228,7 +228,7 @@
> 
>             [% WRAPPER tab_panel tabname="bookings" %]
>                 [% IF ( bookings_count ) %]
>-                    <table id="bookings-table" style="width: 100% !Important;"></table>
>+                    <table id="bookings_table" style="width: 100% !Important;"></table>
>                 [% ELSE %]
>                     <p>Patron has nothing booked.</p>
>                 [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 44098addba..71d2991a93 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -784,7 +784,7 @@
>                 if ( !bookings_table ) {
>                     var today = new Date();
>                     var bookings_table_url = "/api/v1/bookings";
>-                    bookings_table = $('#bookings-table').kohaTable({
>+                    bookings_table = $('#bookings_table').kohaTable({
>                         "ajax": {
>                             "url": bookings_table_url
>                         },
>@@ -796,9 +796,7 @@
>                         "columns": [{
>                             "data": "booking_id",
>                             "title": "Booking ID",
>-                            "visible": false,
>-                            "searchable": false,
>-                            "orderable": false
>+                            "visible": false
>                         },
>                         {
>                             "data": "biblio.title",
>@@ -829,7 +827,7 @@
>                             "searchable": true,
>                             "orderable": true,
>                             "render": function(data, type, row, meta) {
>-                                return $datetime(row.start_date);
>+                                return $date(row.start_date);
>                             }
>                         },
>                         {
>@@ -838,7 +836,7 @@
>                             "searchable": true,
>                             "orderable": true,
>                             "render": function(data, type, row, meta) {
>-                                return $datetime(row.end_date);
>+                                return $date(row.end_date);
>                             }
>                         },
>                         {
>@@ -851,7 +849,7 @@
>                                 return result;
>                             }
>                         }]
>-                    }, [], 1, { patron_id: "[% patron.borrowernumber | html %]", end_date: { ">=": today.toISOString() } });
>+                    }, [], 0, { patron_id: "[% patron.borrowernumber | html %]", end_date: { ">=": today.toISOString() } });
>                 };
>             });
>             // Bookings
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33737: 161045 | 161046 | 161047 | 162253 | 162254 | 162255 | 162256 | 163557 | 164994 | 164995 | 164996 | 164997 | 166513 | 166514 | 166515 | 166516 | 166565 | 166566 | 166567 | 166568 | 166570 | 166573 | 166577