Bug 33737 - Add bookings to patron details
Summary: Add bookings to patron details
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 29002
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-15 14:48 UTC by Martin Renvoize
Modified: 2024-03-20 15:48 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33737: Add bookings tab to patron details (9.00 KB, patch)
2024-01-15 16:19 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Fix patron bookings table display issues (3.54 KB, patch)
2024-01-15 16:19 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Link from patron bookings to biblio bookings (4.37 KB, patch)
2024-01-15 16:19 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Add bookings tab to patron details (9.29 KB, patch)
2024-02-18 17:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Fix patron bookings table display issues (3.54 KB, patch)
2024-02-18 17:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Link from patron bookings to biblio bookings (4.37 KB, patch)
2024-02-18 17:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Fix undefined variable issues (2.47 KB, patch)
2024-02-18 17:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33737: Fix undefined variable issues (2.51 KB, patch)
2024-03-20 15:47 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-05-15 14:48:18 UTC
As part of the bookings workflow, we should add a "bookings" tab to the patron details page.
Comment 1 Esther Melander 2023-12-29 19:15:19 UTC
+1

There is no way to find a booking a patron has scheduled without knowing the title.
Comment 2 Martin Renvoize 2024-01-15 16:19:01 UTC
Created attachment 161045 [details] [review]
Bug 33737: Add bookings tab to patron details
Comment 3 Martin Renvoize 2024-01-15 16:19:03 UTC
Created attachment 161046 [details] [review]
Bug 33737: Fix patron bookings table display issues
Comment 4 Martin Renvoize 2024-01-15 16:19:06 UTC
Created attachment 161047 [details] [review]
Bug 33737: Link from patron bookings to biblio bookings
Comment 5 Martin Renvoize 2024-01-15 16:19:41 UTC
Rebased after splitting from original bug 29002 submission.
Comment 6 Martin AUBEUT 2024-01-23 09:43:26 UTC
The tab was there but when we tried to cancel the booking. it returns an error.
Comment 7 Victor Grousset/tuxayo 2024-01-23 09:44:25 UTC
Also a test plan is needed, we improvised but not knowing the feature, it was difficult
Comment 8 Martin Renvoize 2024-02-18 17:29:21 UTC
Created attachment 162253 [details] [review]
Bug 33737: Add bookings tab to patron details

This patch adds a new 'bookings' tab to the bottom of the members
details pages.  When a patron has any future or current bookings against
their record the tab will display the number of bookings in the tab name
and on clicking the tab a bookings table will display the current and
upcoming bookings.
Comment 9 Martin Renvoize 2024-02-18 17:29:23 UTC
Created attachment 162254 [details] [review]
Bug 33737: Fix patron bookings table display issues
Comment 10 Martin Renvoize 2024-02-18 17:29:26 UTC
Created attachment 162255 [details] [review]
Bug 33737: Link from patron bookings to biblio bookings
Comment 11 Martin Renvoize 2024-02-18 17:29:29 UTC
Created attachment 162256 [details] [review]
Bug 33737: Fix undefined variable issues

This patch resolves the undefined bookings_table variable issue reported
and also further fixes a subsequent undefined timeline bug that was
exposed by the original fix.
Comment 12 Martin Renvoize 2024-02-18 17:30:21 UTC
As an aside, we're using this in production with those customers at ptfs-e who are early adopters of bookings.
Comment 13 ByWater Sandboxes 2024-03-20 15:47:26 UTC
Created attachment 163557 [details] [review]
Bug 33737: Fix undefined variable issues

This patch resolves the undefined bookings_table variable issue reported
and also further fixes a subsequent undefined timeline bug that was
exposed by the original fix.

Signed-off-by: esther <esther@bywatersolutions.com>
Comment 14 Esther Melander 2024-03-20 15:48:30 UTC
My test plan:

1. Search catalog and find a record.
2. Make item on the record bookable.
3. Place booking
4. Navigate to patron account
5. See the bookings tab on the Patron Details page
6. See the item that was booked.

And it worked!