Attachment 166681 Details for Bug 36856 – Bug 36856: Fix marc subfield name in new order from existing biblio

[patch] Bug 36856: Fix marc subfield name in new order from existing biblio

Bug-36856-Fix-marc-subfield-name-in-new-order-from.patch (text/plain), 1.83 KB, created by Fridolin Somers on 2024-05-14 09:48:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2024-05-14 09:48:26 UTC

Size: 1.83 KB

patch

obsolete

>From f6e9aa735191927f8b05f0c7cc0f2058cd42a423 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 14 May 2024 11:41:57 +0200
>Subject: [PATCH] Bug 36856: Fix marc subfield name in new order from existing
> biblio
>
>In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown.
>The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.
>
>Test plan:
>1) Be sure to have an ACQ biblio framework
>2) Enable system preference UseACQFrameworkForBiblioRecords
>3) Go to an acquisition basket
>4) Add a term in 'From an existing record' and submit
>5) On first result click on 'Add order'
>6) Look at 'Catalog details'
>=> Without patch you only see subfield tag and letter : (123a)
>=> With patch you also see subfield name : Name (123a)
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index e9b62396f1..605f99299f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -457,7 +457,7 @@
>                 <ol>
>                     [% FOREACH field IN catalog_details %]
>                         <li class="subfield_line">
>-                            <label>[% field.lib | html %] ([% field.tag | html %][% field.subfield | html %])</label>
>+                            <label>[% field.marc_lib | html %] ([% field.tag | html %][% field.subfield | html %])</label>
>                             [% field.value | html %]
>                         </li>
>                     [% END %]
>-- 
>2.45.0

Actions: View | Diff | Splinter Review

Attachments on bug 36856: 166681 | 166692 | 166913