In form of the bibliographic details when adding an order 'From a new (empty) record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.
(In reply to Fridolin Somers from comment #0) > In form of the bibliographic details when adding an order 'From a new > (empty) record' in a basket, the marc subfield name is not shown. > The template calls [% field.lib | html %] but this comes from > Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives > 'marc_lib'. Oups => adding an order 'From an existing record'
Created attachment 166681 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a)
Created attachment 166692 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 166913 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
No string change, small template change.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12