Bugzilla – Attachment 167556 Details for
Bug 35294
Typo in comment in C4 circulation: barocode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35294: Fix typos in catalogue code comments
Bug-35294-Fix-typos-in-catalogue-code-comments.patch (text/plain), 1.82 KB, created by
David Nind
on 2024-06-06 20:44:57 UTC
(
hide
)
Description:
Bug 35294: Fix typos in catalogue code comments
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-06-06 20:44:57 UTC
Size:
1.82 KB
patch
obsolete
>From fa051cfb802e3bfd239b9fb6850c3c753c60d1aa Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Thu, 6 Jun 2024 13:14:43 +0000 >Subject: [PATCH] Bug 35294: Fix typos in catalogue code comments > >Test plan: >1. git grep -n -E 'barocode|preproccess' to find the files and line # of typos >2. Apply the patch >3. git grep -E 'barocode|proccess' >4. See no results > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > catalogue/itemsearch.pl | 2 +- > catalogue/search.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl >index 1947dc7b6e..43eebf80cd 100755 >--- a/catalogue/itemsearch.pl >+++ b/catalogue/itemsearch.pl >@@ -51,7 +51,7 @@ if (defined $format and $format eq 'json') { > my @f = $cgi->multi_param('f'); > my @q = $cgi->multi_param('q'); > >- # If index indicates the value is a barcode, we need to preproccess it before searching >+ # If index indicates the value is a barcode, we need to preprocess it before searching > for ( my $i = 0; $i < @q; $i++ ) { > $q[$i] = barcodedecode($q[$i]) if $f[$i] eq 'barcode'; > } >diff --git a/catalogue/search.pl b/catalogue/search.pl >index 6430c6ab91..998484d301 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -459,7 +459,7 @@ my $builder = Koha::SearchEngine::QueryBuilder->new( > my $searcher = Koha::SearchEngine::Search->new( > { index => $Koha::SearchEngine::BIBLIOS_INDEX } ); > >-# If index indicates the value is a barocode, we need to preproccess it before searching >+# If index indicates the value is a barcode, we need to preprocess it before searching > for ( my $i = 0; $i < @operands; $i++ ) { > $operands[$i] = barcodedecode($operands[$i]) if (defined($indexes[$i]) && $indexes[$i] eq 'bc'); > } >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35294
:
167498
|
167504
|
167541
|
167547
| 167556