There is a typo in comment in C4 circulation barocode
Created attachment 167498 [details] [review] Bug 35294: fix typo in catalogue/search.pl This patch fixes a typo in a comment To recreate: 1. git grep barocode to find the file and line # of the typo catalogue/search.pl:462:# If index indicates the value is a barocode To Test: 1. Apply patch 2. git grep barocode 3. See no results
Created attachment 167504 [details] [review] Bug 35294: Fix typo in catalogue/search.pl This patch fixes a typo in a comment. Test plan: 1. git grep barocode to find the file and line # of the typo: catalogue/search.pl:462:# If index indicates the value is a barocode 2. Apply the patch. 3. git grep barocode 4. See no results. Signed-off-by: David Nind <david@davidnind.com>
Comment on attachment 167498 [details] [review] Bug 35294: fix typo in catalogue/search.pl I edited the text of the commit message slightly. Hope that is OK.
Created attachment 167541 [details] [review] Bug 35294: Fix typo in catalogue/search.pl This patch fixes a typo in a comment. Test plan: 1. git grep barocode to find the file and line # of the typo: catalogue/search.pl:462:# If index indicates the value is a barocode 2. Apply the patch. 3. git grep barocode 4. See no results. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 167547 [details] [review] Bug 35294: Fix typos in catalogue code comments Test plan: 1. git grep -n -E 'barocode|preproccess' to find the files and line # of typos 2. Apply the patch 3. git grep -E 'barocode|proccess' 4. See no results
When I looked at this again I noticed another typo in the comment that appears in both catalogue/search.pl and catalogue/itemsearch.pl This new patch fixes both typos barocode and preproccess. Should I obsolete the first patch and set this back to needs sign off? Thanks David and Matt.
Comment on attachment 167541 [details] [review] Bug 35294: Fix typo in catalogue/search.pl I think adding a follow-up would have been sufficient. I've obsoleted the original patch, and will add the sign-off lines to the new patch shortly.
Created attachment 167556 [details] [review] Bug 35294: Fix typos in catalogue code comments Test plan: 1. git grep -n -E 'barocode|preproccess' to find the files and line # of typos 2. Apply the patch 3. git grep -E 'barocode|proccess' 4. See no results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.02
Pushed to 23.11.x for 23.11.07
Backported to 23.05.x for 23.05.15