Attachment 167837 Details for Bug 36694 – Bug 36694: (follow-up) Remove some missed instances

[patch] Bug 36694: (follow-up) Remove some missed instances

Bug-36694-follow-up-Remove-some-missed-instances.patch (text/plain), 4.32 KB, created by Owen Leonard on 2024-06-18 12:11:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-06-18 12:11:43 UTC

Size: 4.32 KB

patch

obsolete

>From 172862b83fee95a1d4e70c1418334be5e1cd46b4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 6 Jun 2024 12:13:38 +0000
>Subject: [PATCH] Bug 36694: (follow-up) Remove some missed instances
>
>This patch removes some missed HCSticky code/mentions as well as the
>entry on the About page.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/authorities/authorities.tt             | 2 --
> koha-tmpl/intranet-tmpl/prog/js/members-menu.js            | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/staff-global.js            | 5 +----
> t/mock_templates/intranet-tmpl/prog/en/modules/about.tt    | 7 +------
> 4 files changed, 3 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index e3e73c3809..62985ba500 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -106,7 +106,6 @@
> 
>         $("body").on("click", ".show-errors", function(e){
>             document.getElementById("form-errors").scrollIntoView();
>-            Sticky.hcSticky('refresh');
>         });
> 
>         $("#preview").click(function () {
>@@ -371,7 +370,6 @@
>         } else {
>             $("#check_errors").html( StrAlert );
>             $('html, body').animate({ scrollTop: 0 }, 'fast');
>-            Sticky.hcSticky('refresh');
>             return false;
>         }
>     }
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>index 2a9b0cec69..88a95d5e5e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/members-menu.js
>@@ -1,4 +1,4 @@
>-/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_delete_borrowers CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Sticky Cookies*/
>+/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_delete_borrowers CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Cookies*/
> 
> $(document).ready(function(){
>     searchfield_date_tooltip("");
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>index 2f60702e7a..c2db932606 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>@@ -1,4 +1,4 @@
>-/* global shortcut delBasket Sticky AUDIO_ALERT_PATH Cookies */
>+/* global shortcut delBasket AUDIO_ALERT_PATH Cookies */
> /* exported addBibToContext delBibToContext escape_str escape_price openWindow _ removeFocus toUC confirmDelete confirmClone playSound */
> if (KOHA === undefined) var KOHA = {};
> 
>@@ -168,9 +168,6 @@ $(document).ready(function () {
>     $(".toggle_element").on("click", function (e) {
>         e.preventDefault();
>         $($(this).data("element")).toggle();
>-        if (typeof Sticky !== "undefined" && typeof hcSticky === "function") {
>-            Sticky.hcSticky("update");
>-        }
>     });
> 
>     var navmenulist = $("#navmenulist");
>diff --git a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
>index 0f5675a5f8..765fe248d1 100644
>--- a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
>+++ b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt
>@@ -1083,11 +1083,6 @@
>             <a href="https://web.archive.org/web/20160819153233/http://orangoo.com:80/labs/GreyBox">GreyBox JavaScript Library v5.54</a>: <a href="https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html">GNU Lesser General Public License, version 2.1</a>
>         </p>
> 
>-        <h2>HC Sticky</h2>
>-        <p>
>-            <a href="https://somewebmedia.github.io/hc-sticky/">HC Sticky JavaScript library v2.2.7</a>: <a href="https://github.com/somewebmedia/hc-sticky/blob/v2.2.7/LICENSE">MIT License</a>
>-        </p>
>-
>         <h2>Highlight</h2>
>         <p>
>             <a href="https://johannburkard.de/blog/programming/javascript/highlight-javascript-text-higlighting-jquery-plugin.html">Highlight jQuery Plugin v5.0</a>: MIT License
>@@ -1339,4 +1334,4 @@
>             mother of Simon and Jeremy, and grandmother of Ben, Toby, Anna, Charlotte and Billy.
>         </p>
>     [% END # tab=dedications %]
>-[% END %]
>\ No newline at end of file
>+[% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36694: 165489 | 165490 | 165491 | 165492 | 165493 | 165576 | 165582 | 165584 | 165587 | 165680 | 165682 | 165683 | 165684 | 165686 | 165756 | 165757 | 165758 | 165759 | 165760 | 165761 | 165762 | 165763 | 165764 | 165765 | 165766 | 165767 | 166703 | 166704 | 166705 | 166706 | 166707 | 166708 | 166709 | 166710 | 166711 | 166712 | 166713 | 166714 | 166715 | 166940 | 167507 | 167508 | 167509 | 167510 | 167511 | 167512 | 167513 | 167514 | 167515 | 167516 | 167517 | 167518 | 167519 | 167520 | 167539 | 167823 | 167824 | 167825 | 167826 | 167827 | 167828 | 167829 | 167830 | 167831 | 167832 | 167833 | 167834 | 167835 | 167836 | 167837 | 169110 | 169111 | 169112 | 169113 | 169114 | 169115 | 169116 | 169117 | 169118 | 169119 | 169120 | 169121 | 169122 | 169123 | 169124 | 169125 | 171080 | 171081 | 171082 | 171083 | 171084 | 171085 | 171086 | 171087 | 171088 | 171089 | 171090 | 171091 | 171092 | 171093 | 171094 | 171095 | 171852 | 171853 | 171854 | 171855 | 171856 | 171857 | 171858 | 171859 | 171860 | 171861 | 171862 | 171863 | 171864 | 171865 | 171866 | 171867