CSS sticky is now widely available across major browsers. I think we can use it instead of the HC sticky library now.
Created attachment 165489 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar
Created attachment 165490 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt
Created attachment 165491 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 165492 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 165493 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element
Created attachment 165576 [details] [review] Bug 36694: Set sticky element top to -1px
Created attachment 165582 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 165584 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt
Created attachment 165587 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages
Created attachment 165680 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages
Created attachment 165682 [details] [review] Bug 36694: Remove HC sticky from members/ pages
Created attachment 165683 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages
Created attachment 165684 [details] [review] Bug 36694: Remove HC sticky from OPAC pages
Created attachment 165686 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick.
The patches no longer applies (Remove remaining HC stick assets - sha1/fake ancestor error) 8-(...: git bz apply 36694 Bug 36694 - Remove HC Sticky library in favor of CSS 165489 - Bug 36694: Remove HC sticky from patron search searchbar 165490 - Bug 36694: Remove HC sticky from acqui/basket.tt 165493 - Bug 36694: Add JS observer to detect stuck sticky element 165576 - Bug 36694: Set sticky element top to -1px 165582 - Bug 36694: Remove HC sticky from acqui/supplier.tt 165584 - Bug 36694: Remove HC sticky from preferences.tt/authorities.tt 165587 - Bug 36694: Remove HC sticky from catalogue/ pages 165680 - Bug 36694: Remove HC stikcy from cataloguing/ pages 165682 - Bug 36694: Remove HC sticky from members/ pages 165683 - Bug 36694: Remove HC sticky from remaining staff pages 165684 - Bug 36694: Remove HC sticky from OPAC pages 165686 - Bug 36694: Remove remaining HC stick assets Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36694: Remove HC sticky from patron search searchbar Applying: Bug 36694: Remove HC sticky from acqui/basket.tt Applying: Bug 36694: Add JS observer to detect stuck sticky element Applying: Bug 36694: Set sticky element top to -1px Applying: Bug 36694: Remove HC sticky from acqui/supplier.tt Applying: Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Applying: Bug 36694: Remove HC sticky from catalogue/ pages Applying: Bug 36694: Remove HC stikcy from cataloguing/ pages Applying: Bug 36694: Remove HC sticky from members/ pages Applying: Bug 36694: Remove HC sticky from remaining staff pages Applying: Bug 36694: Remove HC sticky from OPAC pages Applying: Bug 36694: Remove remaining HC stick assets error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt). error: could not build fake ancestor Patch failed at 0001 Bug 36694: Remove remaining HC stick assets hint: Use 'git am --show-current-patch=diff' to see the failed patch
Created attachment 165756 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar
Created attachment 165757 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt
Created attachment 165758 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element
Created attachment 165759 [details] [review] Bug 36694: Set sticky element top to -1px
Created attachment 165760 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 165761 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt
Created attachment 165762 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages
Created attachment 165763 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages
Created attachment 165764 [details] [review] Bug 36694: Remove HC sticky from members/ pages
Created attachment 165765 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages
Created attachment 165766 [details] [review] Bug 36694: Remove HC sticky from OPAC pages
Created attachment 165767 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick.
rebased for current main
I've listed the things that didn't work as expected, or that I'm not sure of (more details below under the respective headings): 1. Patron search: landing page (without any searches) doesn't display the toolbar above the browse by last name area. 2. Patron permissions page: the wrong toolbar is displayed when scrolling (normal edit patron toolbar, instead of the permissions toolbar). 3. Patron information: when you add new patrons, or edit existing patrons, the toolbar does not stick. 4. Authority search: The only place I could see where the toolbar is sticky is when adding or editing authorities. I didn't see any sticky toolbar when searching and on the search results page. Things noted that are different or not working as expected ========================================================== 3. Patron search: with patch applied, the "Sticky" menu isn't displayed when you go to the patron landing page - it just displays Browse by last name: A, B, C, etc. Before the patch it included a toolbar with Select all, clear all, greyed out options for adding to list, merging, etc. Once there are results, this toolbar is displayed. 12. Patron permissions page: Patrons > Search (from filters to the left) > select any patron > More > Set permissions > scroll down the page. The sticky toolbar is the wrong one - it is the normal patron actions (Edit - Change password - Duplicate - etc.). Before the patch it was the permissions toolbar (Save - Cancel - Show all - etc.). 13. Patron information: . Add or edit a patron (memberentry): Patrons > + New patron > Patron > scroll down. Result: The toolbar DOES NOT STICK as you scroll down (for both add and edit). It did before the patch was applied. Things I'm not sure of ====================== 7. Authority search: Authorities > click submit button in header. Result: search results displayed. NO sticker toolbar when scrolling down the page. The only place I could find the sticky working before and after the patch was when adding or editing an authority. Worked as expected ================== 3. Patron search: Patrons > click Search. Result: all patrons listed, toolbar sticks as you scroll down. 4. Acquisitions - add a vendor: Acquisitions > + New vendor. Result: new vendor form displayed, toolbar sticks as you scroll down. 5. Acquisitions - add a basket: . Acquisitions > Mange orders section > Search. Result: list of orders for "My Vendor" displayed. . + New > Basket > add a basket name > Save. Result: Page for the basket displayed. . Scroll down the page. Result: toolbar sticks as you scroll down. 6. System preferences: Administration > System preferences > select OPAC > scroll down. Result: toolbar sticks as you scroll down. 8. Advanced search: Search (in toolbar at top) > Advanced search > scroll down. Result: toolbar sticks as you scroll down. 9. Item search: Search (in toolbar at top) > Item search > scroll down. Result: toolbar bar sticks as you scroll down. NOTE: Before the patch the toolbar didn't stick. 10. Catalog search: select 'Search catalog' in the header, enter a search term, press the submit button/arrow, and scroll down on the results page. Result: The toolbar sticks as you scroll down. 11. Add a bibliographic record, or edit one: Cataloging > + New record, and then scroll down. Result: The toolbar sticks as you scroll down. 12. Patron information: . Patron details page (moremembers): Patrons > Search > Select a patron > Details. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Patron check out page: Patrons > Search > Select a patron > Check out. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Other sections: Add some data (if required) for each of the other sections - accounting, routing lists, circulation history, holds history, modification log (if you have some entries, such as check outs and check ins, the table header stays at the top of the page), notices, statistics, purchase suggestions (something is not quite right with this screen for adding new purchase suggestions - no entry form - but I don't think it is related to this bug; if you add a purchase suggestion via acquistions, the list of suggestions displays and the normal patron menu is sticky). Result: toolbar sticks as you scroll down. 14. Place multiple holds on a record: For any record from the normal view, click 'Place hold'. Add holds for multiple patrons. Result: Under the 'Existing holds' section, the toolbar sticks as you scroll down. 15. HTML customizations: Tools > Additional tools > HTML customizations. Add a new customization (+New entry). Edit a customization - select 'Edit' under actions for an existing entry. Select pages, then + New entry. Select pages, then + New entry. Results: toolbars stick as you scroll down. 16. Cataloging > Automatic item modifications by age. Add a rule, then edit rules. The toolbar should stick. Result: toolbar sticks as you scroll down. 17. Edit a notice, expand an area (such as Email), and scroll down. The toolbar should stick. Result: toolbar sticks as you scroll down. 18. Tools > Log viewer > Submit. Under Log entries, the toolbar should stick. Result: toolbar sticks as you scroll down. 19. Lists: Create some lists and add several items to them. Toolbar should be sticky when you scroll down the items in the list. Result: toolbar sticks as you scroll down. 20. Add many items to an OPAC cart. Make sure the toolbar sticks. Result: toolbar sticks as you scroll down. 21. Try the OPAC results, the toolbar should stick. Result: toolbar sticks as you scroll down. 22. Add many items to a list, on the OPAC list display the toolbar should stick. Result: toolbar sticks as you scroll down.
Wow David! Thanks for testing so thoroughly.
(In reply to David Nind from comment #29) > 1. Patron search: landing page (without any searches) doesn't display the > toolbar above the browse by last name area. If the toolbar displays when there are results I think this is actually the desired outcome. I think it was a bug that the toolbar displayed before results were shown. > 4. Authority search: I didn't see any sticky toolbar when > searching and on the search results page. I think that's the same as in main.
Created attachment 166703 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar
Created attachment 166704 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt
Created attachment 166705 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element
Created attachment 166706 [details] [review] Bug 36694: Set sticky element top to -1px
Created attachment 166707 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 166708 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt
Created attachment 166709 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages
Created attachment 166710 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages
Created attachment 166711 [details] [review] Bug 36694: Remove HC sticky from members/ pages
Created attachment 166712 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages
Created attachment 166713 [details] [review] Bug 36694: Remove HC sticky from OPAC pages
Created attachment 166714 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick.
Created attachment 166715 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky
I've addressed David's findings and have reset this to NSO.
(In reply to Lucas Gass from comment #45) > I've addressed David's findings and have reset this to NSO. Thanks Lucas! I just re-tested the things I noted with potential issues. With the patron permissions page: - The correct toolbar is now shown - However: . the Show all/Hide all buttons on the toolbar don't seem to be working now . the "Show details" link/button in the page doesn't expand to show the permission details
(In reply to David Nind from comment #46) > (In reply to Lucas Gass from comment #45) > > I've addressed David's findings and have reset this to NSO. > > Thanks Lucas! > > I just re-tested the things I noted with potential issues. > > With the patron permissions page: > - The correct toolbar is now shown > - However: > . the Show all/Hide all buttons on the toolbar don't seem to be working now > . the "Show details" link/button in the page doesn't expand to show the > permission details Good catch!
Created attachment 166940 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt
QA notes. In koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss 88:// Sticky footer styles It's not related to this. (took long to confirm >_<) --- Missing occurrences: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt 109: Sticky.hcSticky('refresh'); 374: Sticky.hcSticky('refresh'); koha-tmpl/intranet-tmpl/prog/js/staff-global.js 1:/* global shortcut delBasket Sticky AUDIO_ALERT_PATH Cookies */ 171: if (typeof Sticky !== "undefined" && typeof hcSticky === "function") { 172: Sticky.hcSticky("update"); Pretty sure here also: koha-tmpl/intranet-tmpl/prog/js/members-menu.js 1:/* global borrowernumber advsearch dateformat __ CAN_user_borrowers_delete_borrowers CAN_user_borrowers_edit_borrowers number_of_adult_categories destination Sticky Cookies*/
Do we reserve enhancement severity for functional stuff. Or do refactoring that don't fix any bug are also enhancements?
Thanks for fixing the permissions area - this all seems to work as expected now.
(In reply to Victor Grousset/tuxayo from comment #50) > Do we reserve enhancement severity for functional stuff. Or do refactoring > that don't fix any bug are also enhancements? I'd say that something not fixing a bug would be an enhancement, also refactorings might not be suitable for backporting unless needed for other patches.
(In reply to Victor Grousset/tuxayo from comment #50) > Do we reserve enhancement severity for functional stuff. Or do refactoring > that don't fix any bug are also enhancements? I think this is an enhancement.
Ok, switching severity :) (In reply to Victor Grousset/tuxayo from comment #49) > QA notes. > > In > koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss > 88:// Sticky footer styles > > It's not related to this. (took long to confirm >_<) BTW, I meant that this is a remaining thing and that it's not a problem because it's not about HC Sticky
Created attachment 167507 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar
Created attachment 167508 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt
Created attachment 167509 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element
Created attachment 167510 [details] [review] Bug 36694: Set sticky element top to -1px
Created attachment 167511 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt
Created attachment 167512 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt
Created attachment 167513 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages
Created attachment 167514 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages
Created attachment 167515 [details] [review] Bug 36694: Remove HC sticky from members/ pages
Created attachment 167516 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages
Created attachment 167517 [details] [review] Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 167518 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick.
Created attachment 167519 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky
Created attachment 167520 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt
Rebased. (compared the diffs with the rebased version of the conflicting commit and the original to double check that the rebase didn't introduce unwanted changes) There is still comment 49 though.
Created attachment 167539 [details] [review] Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page.
(In reply to Victor Grousset/tuxayo from comment #69) > There is still comment 49 though. I think my follow-up takes care of those, but I'm leaving this as Failed QA because of an issue I saw with acqui/basket.tt. The sticky toolbar works fine until it gets to the sticky header on the DataTable. In Firefox the result is a weird jittery effect where you can't scroll down. In Chromium there's not the jittery effect but the sticky toolbar overlaps the sticky DataTable header. I assume we'll see this issue on any page that combines a sticky toolbar and a sticky DataTable header.
> In Firefox the result is a weird jittery effect where you can't scroll down. I am unable to recreate this. > In Chromium there's not the jittery effect but the sticky toolbar overlaps > the sticky DataTable header. I do recreate this, in both Chrome and FF.
Tested and works for me in both Chrome and Safari.
> I am unable to recreate this. Oh no it's dependent on the number of elements in the table and probably the screen size. [U+1F62D][U+1F62D][U+1F62D] And the size of each line which depends on the picked record. [U+1FAE0] So here is a working (as in "failed successfully") combination. 0. Firefox 1. Add 3 times in a basket the record 279 (Linux kernel development) Shortcut: After adding once, you can hit back in the browser and click save again. 2. Apply patches and yarn build 3. While stuff builds: Enable responsive design mode on your tab (ctrl shift M or equivalent) 4. Set the viewport size to 1800x800 5. refresh page 6. You can't scroll to the bottom, it keeps glitching back up. On Chromium, Device Mode with viewport 1400x700 (mind that the zoom stays at 100% and that Chromium doesn't completely switch the DPI to better emulate mobile devices, it might fail to reproduce) And then scroll step by step and midpage the two stickies will start fighting. (with the top never being displayed before that)
Hey I still get the same results without the patches! :o Double checked on a sandbox. And on a 23.11 demo. And it doesn't happen in a 22.11 demo. How weird that such a specific behavior wouldn't be changed. Anyway, ready for signoff I guess.
QA note: After looking for all occurrences of "sticky" (rg -i "sticky\b") There doesn't seem to be anything relevant related to HC Sticky left. :)
Created attachment 167823 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167824 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167825 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167826 [details] [review] Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167827 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167828 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167829 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167830 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167831 [details] [review] Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167832 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167833 [details] [review] Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167834 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167835 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167836 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167837 [details] [review] Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Owen Leonard from comment #71) > In Firefox the result is a weird jittery effect where you can't scroll down. Today I observed this behavior in main so I guess that's just a thing!
Created attachment 169110 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169111 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169112 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169113 [details] [review] Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169114 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169115 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169116 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169117 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169118 [details] [review] Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169119 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169120 [details] [review] Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169121 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169122 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169123 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169124 [details] [review] Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 169125 [details] [review] Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written.
Rebased.
> 13. Try each of the other members pages like memberentry.pl, > moremember.pl, circulation.pl. On each of the pages the toolbar > should stick. moremember.pl, circulation.pl => nope but neither on main Was there something about this or can this be skipped? ---- Additional testing: - marc21_field_008 cataloguing plugin - label batch content - patron card creator batch content
Created attachment 171080 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171081 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171082 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171083 [details] [review] Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171084 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171085 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171086 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171087 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171088 [details] [review] Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171089 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171090 [details] [review] Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171091 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171092 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171093 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171094 [details] [review] Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 171095 [details] [review] Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written.
I think the only remaining thing to get to passed QA is the finding in Comment 110. Whether there is still something to test in moremember.pl and circulation.pl. Or maybe there is a regression that broke the stickiness in these pages after the test plan here was written.
Since those templates are unchanged and there have never been floating toolbars on those pages I think there is nothing to test on those pages.
Created attachment 171852 [details] [review] Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171853 [details] [review] Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171854 [details] [review] Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171855 [details] [review] Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171856 [details] [review] Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171857 [details] [review] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171858 [details] [review] Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171859 [details] [review] Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171860 [details] [review] Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171861 [details] [review] Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171862 [details] [review] Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171863 [details] [review] Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171864 [details] [review] Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171865 [details] [review] Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171866 [details] [review] Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 171867 [details] [review] Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
(In reply to Owen Leonard from comment #128) > Since those templates are unchanged and there have never been floating > toolbars on those pages I think there is nothing to test on those pages. Great, no issue then! :D Works, makes sense, QA script happy, code looks good, passing QA :)
3. Do a patron search, the toolbar should stick as you scroll down. Didn't we have both the "search header" (select all, etc.) and the table header (thead) sticky at some point?
> Didn't we have both the "search header" (select all, etc.) and the table header (thead) sticky at some point? Good finding! confirmed for 22.11, 23.05, 23.11 main, 24.05 doesn't have it. opened bug 37992 since it's not caused by removal of HC Sticky