Bugzilla – Attachment 167851 Details for
Bug 36868
Add ability to automatically empty cart after placing holds ( staff interface and OPAC )
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36868: (follow-up) Fix staff interface code
Bug-36868-follow-up-Fix-staff-interface-code.patch (text/plain), 2.91 KB, created by
Lucas Gass (lukeg)
on 2024-06-18 14:16:44 UTC
(
hide
)
Description:
Bug 36868: (follow-up) Fix staff interface code
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-06-18 14:16:44 UTC
Size:
2.91 KB
patch
obsolete
>From ebab1c06705aaa130dcc56d77ba33483efef33e1 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 18 Jun 2024 14:15:32 +0000 >Subject: [PATCH] Bug 36868: (follow-up) Fix staff interface code > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- > reserve/placerequest.pl | 3 ++- > reserve/request.pl | 5 ++--- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index c3e0581043..f1fbca6db0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1883,8 +1883,8 @@ > [% END %] > > [% IF successful_holds && Koha.Preference('AutoDeleteFromCartWhenHoldPlaced').grep('staff').size %] >- [% FOREACH biblionumber in successful_holds %] >- delSingleRecord('[% biblionumber | html %]'); >+ [% FOREACH success IN successful_holds.split('\|') %] >+ delSingleRecord('[% success | html %]'); > [% END %] > [% END %] > >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index 8bc4391fba..8b9dcad010 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -168,7 +168,8 @@ if ( $op eq 'cud-placerequest' && $patron ) { > foreach my $msg ( keys %failed_holds ) { > push( @failed_hold_msgs, $msg ); > } >- $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs, successful_holds => \@successful_biblionumbers, ); >+ $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs ); >+ $redirect_url .= "&successful_holds=" . join('|', @successful_biblionumbers); > print $input->redirect($redirect_url); > } > elsif ( $borrowernumber eq '' ) { >diff --git a/reserve/request.pl b/reserve/request.pl >index 7992f2a7ea..a36ce023a2 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -89,7 +89,7 @@ my $messages; > my $exceeded_maxreserves; > my $exceeded_holds_per_record; > my @failed_holds = $input->multi_param('failed_holds'); >-my @successful_holds = $input->multi_param('successful_holds'); >+my @successful_holds = $input->param('successful_holds'); > my $op = $input->param('op') || q{}; > > if ( $op eq 'cud-move' ) { >@@ -722,8 +722,7 @@ $template->param( biblionumbers => \@biblionumbers ); > $template->param( pickup => $pickup || C4::Context->userenv->{branch} ); > > $template->param(borrowernumber => $borrowernumber_hold); >- >-$template->param( failed_holds => \@failed_holds, successful_holds => \@successful_holds ); >+$template->param( failed_holds => \@failed_holds, successful_holds => @successful_holds ); > > # printout the page > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36868
:
166834
|
166835
|
167558
|
167695
|
167699
|
167700
|
167701
|
167851
|
167852
|
167853
|
167854
|
167855
|
177760
|
177761
|
177762
|
177763
|
178640
|
178700
|
178701