Attachment 168027 Details for Bug 37059 – Bug 37059: Fix insert button in notices and slips

[patch] Bug 37059: Fix insert button in notices and slips

Bug-37059-Fix-insert-button-in-notices-and-slips.patch (text/plain), 1.30 KB, created by Eric Garcia on 2024-06-24 16:17:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Garcia

Created: 2024-06-24 16:17:03 UTC

Size: 1.30 KB

patch

obsolete

>From 055eedbcb0bbb3c9aabce5f553784acb525530a7 Mon Sep 17 00:00:00 2001
>From: Brendan Lawlor <blawlor@clamsnet.org>
>Date: Mon, 24 Jun 2024 14:54:05 +0000
>Subject: [PATCH] Bug 37059: Fix insert button in notices and slips
>
>This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel'
>
>To Test:
>1. Edit any notice or slip and try to use the insert button
>2. Nothing happens
>3. Apply patch and refresh the browser
>4. Edit any notice or slip and use the insert button
>5. Confirm the parameters are inserted into the tempalte as expected.
>
>Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/letter.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/letter.js b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>index 44524c0452..3c825f961d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/letter.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/letter.js
>@@ -235,7 +235,7 @@ $(document).ready(function() {
>     });
> 
>     function insertValueQuery(containerid) {
>-        var fieldset = $("#" + containerid);
>+        var fieldset = $("#" + containerid + "_panel");
>         var myQuery = $(fieldset).find('textarea[name="content"]');
>         var myListBox = $(fieldset).find('select[name="SQLfieldname"]');
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37059: 168016 | 168027 | 168028