Bugzilla – Attachment 168113 Details for
Bug 36970
(Bug 34160 follow-up) Barcode should be html filtered, not uri filtered in holds queue view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
Bug-36970-Bug-34160-follow-up-Barcode-should-be-ht.patch (text/plain), 2.51 KB, created by
Nick Clemens (kidclamp)
on 2024-06-26 00:45:11 UTC
(
hide
)
Description:
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-06-26 00:45:11 UTC
Size:
2.51 KB
patch
obsolete
>From 27b68935d1f478ff8871d2b9a63181f4189e518a Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Mon, 27 May 2024 21:43:00 +0000 >Subject: [PATCH] Bug 36970: (Bug 34160 follow-up) Barcode should be html > filtered, not uri filtered > >If a barcode (in rare cases) contains a space, with bug 34160, it is >converted into %20 in holds queue view (because of mistakenly applied >uri filter). > >Nota bene, in parallel lines of view_holdsqueue.tt a right filter is >used for the barcode. > >Test plan: >========== >1. Have an item with the barcode containing a space. >2. Make a hold on it, run build_holds_queue.pl >3. Go to Circulation > Holds queue ; select your branch etc. >4. You should see '%20' instead of the space in the barcode. >5. Apply the patch, restart_all. >6. Repeat p. 3. You should now see the space in the barcode. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index 49f23421253..ce052433086 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -202,7 +202,7 @@ > [% ELSIF itemsloo.item.item_group %] > <strong><a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% itemsloo.itemnumber | uri %]&biblionumber=[% itemsloo.biblionumber | uri %]#item[% itemsloo.itemnumber | uri %]">[% itemsloo.barcode | html %]</a></strong> <em>or any item from item group <strong>[% itemsloo.item.item_group.description | html %]</strong></em> > [% ELSE %] >- <strong><a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% itemsloo.itemnumber | uri %]&biblionumber=[% itemsloo.biblionumber | uri %]#item[% itemsloo.itemnumber | uri %]">[% itemsloo.barcode | uri %]</a></strong> <em>or any available</em> >+ <strong><a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% itemsloo.itemnumber | uri %]&biblionumber=[% itemsloo.biblionumber | uri %]#item[% itemsloo.itemnumber | uri %]">[% itemsloo.barcode | html %]</a></strong> <em>or any available</em> > [% END %] > </td> > <td class="hq-patron"> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36970
:
167196
|
167197
| 168113