If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter).
Created attachment 167196 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode.
Created attachment 167197 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Running the holds queue builder: misc/cronjobs/holds/build_holds_queue.pl
Created attachment 168113 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
*** Bug 37847 has been marked as a duplicate of this bug. ***