Attachment 168665 Details for Bug 37285 – Bug 37285: Printing lists only prints the ten first results

[patch] Bug 37285: Printing lists only prints the ten first results

Bug-37285-Printing-lists-only-prints-the-ten-first.patch (text/plain), 1.48 KB, created by Baptiste Wojtkowski (bwoj) on 2024-07-09 14:34:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Baptiste Wojtkowski (bwoj)

Created: 2024-07-09 14:34:49 UTC

Size: 1.48 KB

patch

obsolete

>From 59e03dae442e31a271f18cdb0ff506119032ec83 Mon Sep 17 00:00:00 2001
>From: Baptiste Wojtkowski <bski@laposte.net>
>Date: Tue, 9 Jul 2024 16:08:39 +0200
>Subject: [PATCH] Bug 37285: Printing lists only prints the ten first results
>
>GIVEN koha in a version later than 22.11, a list with more than ten entries
>WHEN the user tries to print the list
>THEN only the ten first results are printed
>
>EXPECTED THEN all results are printed
>
>It looks like it is an undesired effect of BZ36858. Page remains set
>even while printing, therefore, however the number of rows is not set,
>default value (10) is used.
>
>TEST PLAN
>
>1 - create a list with more than 10 items
>2 - print the list -> there is a pagination and that only 10 items
>  are printed
>Apply patch
>3 - print the list again -> every items are being printed
>---
> virtualshelves/shelves.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl
>index badd78f..74228fa 100755
>--- a/virtualshelves/shelves.pl
>+++ b/virtualshelves/shelves.pl
>@@ -276,7 +276,9 @@ if ( $op eq 'view' ) {
>             my $direction = $query->param('direction') || 'asc';
>             $direction = 'asc' if $direction ne 'asc' and $direction ne 'desc';
>             my $rows;
>-            unless ( $query->param('print') ) {
>+            if ( $query->param('print') ) {
>+                $page="";
>+            } else {
>                 $rows = C4::Context->preference('numSearchResults') || 20;
>             }
> 
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 37285: 168665 | 168673 | 169566