Bug 37285 - Printing lists only prints the ten first results
Summary: Printing lists only prints the ten first results
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-09 09:41 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2024-09-10 14:50 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:


Attachments
Bug 37285: Printing lists only prints the ten first results (1.48 KB, patch)
2024-07-09 14:34 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 37285: Printing lists only prints the ten first results (1.53 KB, patch)
2024-07-09 17:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37285: QA Perl Tidy (836 bytes, patch)
2024-07-25 15:23 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2024-07-09 09:41:44 UTC
GIVEN koha in a version later than 22.11, a list with more than ten entries
WHEN the user tries to print the list
THEN only the ten first results are printed

EXPECTED THEN all results are printed
Comment 1 Baptiste Wojtkowski (bwoj) 2024-07-09 14:34:49 UTC
Created attachment 168665 [details] [review]
Bug 37285: Printing lists only prints the ten first results

GIVEN koha in a version later than 22.11, a list with more than ten entries
WHEN the user tries to print the list
THEN only the ten first results are printed

EXPECTED THEN all results are printed

It looks like it is an undesired effect of BZ36858. Page remains set
even while printing, therefore, however the number of rows is not set,
default value (10) is used.

TEST PLAN

1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
Apply patch
3 - print the list again -> every items are being printed
Comment 2 Owen Leonard 2024-07-09 17:18:14 UTC
Created attachment 168673 [details] [review]
Bug 37285: Printing lists only prints the ten first results

GIVEN koha in a version later than 22.11, a list with more than ten entries
WHEN the user tries to print the list
THEN only the ten first results are printed

EXPECTED THEN all results are printed

It looks like it is an undesired effect of BZ36858. Page remains set
even while printing, therefore, however the number of rows is not set,
default value (10) is used.

TEST PLAN

1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
Apply patch
3 - print the list again -> every items are being printed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Laura Escamilla 2024-07-25 15:23:44 UTC
Created attachment 169566 [details] [review]
Bug 37285: QA Perl Tidy

Looks great! QA tool is happy, passing QA.
Comment 4 Martin Renvoize 2024-07-26 12:55:55 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass 2024-08-29 15:06:46 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 6 Fridolin Somers 2024-09-10 14:50:19 UTC
Pushed to 23.11.x for 23.11.09