Attachment 168683 Details for Bug 36276 – Bug 36276: Fix editing of identity provider and domains

[patch] Bug 36276: Fix editing of identity provider and domains

Bug-36276-Fix-editing-of-identity-provider-and-dom.patch (text/plain), 1.95 KB, created by David Nind on 2024-07-09 19:14:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-07-09 19:14:26 UTC

Size: 1.95 KB

patch

obsolete

>From 6956b3e0031dfcd8cc35b22de6191155ac4b628e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 9 Jul 2024 18:40:33 +0000
>Subject: [PATCH] Bug 36276: Fix editing of identity provider and domains
>
>This patch fixes identity_providers.pl to remove the "cud-" prefix for
>two operations which are not POSTed: editing identity providers and
>editing domains.
>
>To test, apply the patch and restart services.
>
>- Go to Administration -> Identity providers.
>- If necessary, create an identity provider and then click "Manage
>  domains" -> New identity provider domain to create a new domain.
>- From the list of domains, click "Edit"
>- The edit form should appear with all the correct details prefilled.
>  - Check that the page title, breadcrumbs, and page header all show the
>    correct domain.
>  - Make a change to the domain and confirm that the changes are saved.
>
>- From the list of identity providers, click "Edit"
>- This form should also load correctly.
>- Submitted changes should be saved correctly.
>
>Sponsored-by: Athens County Public Libraries
>Signed-off-by: David Nind <david@davidnind.com>
>---
> admin/identity_providers.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/admin/identity_providers.pl b/admin/identity_providers.pl
>index 27622ae8dc..74416f6aa7 100755
>--- a/admin/identity_providers.pl
>+++ b/admin/identity_providers.pl
>@@ -155,7 +155,7 @@ elsif ( $domain_ops && $op eq 'cud-add' ) {
>     # list servers after adding
>     $op = 'list';
> }
>-elsif ( !$domain_ops && $op eq 'cud-edit_form' ) {
>+elsif ( !$domain_ops && $op eq 'edit_form' ) {
> 
>     if ( $identity_provider ) {
>         $template->param(
>@@ -171,7 +171,7 @@ elsif ( !$domain_ops && $op eq 'cud-edit_form' ) {
>             };
>     }
> }
>-elsif ( $domain_ops && $op eq 'cud-edit_form' ) {
>+elsif ( $domain_ops && $op eq 'edit_form' ) {
>     my $identity_provider_domain_id = $input->param('identity_provider_domain_id');
>     my $identity_provider_domain;
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36276: 168682 | 168683 | 168686