Once an identity provider is created, it is no longer possible to easily edit it, as the form for editing the identity provider contains no value. Moreover, the provider's name is replace with " (quotation mark). Steps to reproduce: 1. Launch KTD or Koha instance using up-to-date master branch. 2. In the Administration menu, go to the Identity Providers page. 3. Click on the button to create a new identity provider. 4. Fill in the required fields, using test data. 5. Save the identity provider. 6. Click the "Edit" button for the newly created identity provider. 7. Notice that the form's fields are empty and the provider's name has been changed to ".
I can confirm this behaviour.
I can confirm this, too. Happens also, if you want to edit an Identity Provider Domain.
Created attachment 168682 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries
Created attachment 168683 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168686 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Thanks, Owen. Legend!
For my understanding... I thought that any operation that requires a data change should use POST and cud- - Why are we moving the other direction here with these patches?
Pushed for 24.11! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #7) > For my understanding... I thought that any operation that requires a data > change should use POST and cud- - Why are we moving the other direction here > with these patches? The edit_form op is loading the form, it's read only to populate the page. When edits are saved the op is 'cud-edit_save'
(In reply to Nick Clemens (kidclamp) from comment #9) > (In reply to Katrin Fischer from comment #7) > > For my understanding... I thought that any operation that requires a data > > change should use POST and cud- - Why are we moving the other direction here > > with these patches? > > The edit_form op is loading the form, it's read only to populate the page. > When edits are saved the op is 'cud-edit_save' Thanks for explaining!
Backported to 24.05.x for upcoming 24.05.04
CUD not in 23.11.x
This fixes a bug - no change to the interface, no changes required to the manual.