Bugzilla – Attachment 168685 Details for
Bug 37294
Generate next button in serials not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37294: Add modal to generate next
Bug-37294-Add-modal-to-generate-next.patch (text/plain), 4.21 KB, created by
Lucas Gass (lukeg)
on 2024-07-09 20:20:11 UTC
(
hide
)
Description:
Bug 37294: Add modal to generate next
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-07-09 20:20:11 UTC
Size:
4.21 KB
patch
obsolete
>From 6547934403ba7ecfbc9f33906162fcb746d6dc84 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 9 Jul 2024 20:19:05 +0000 >Subject: [PATCH] Bug 37294: Add modal to generate next > >To test: >1. Serials -> Create or find a subscription >2. Receive the subscription >3. Save >4. Click 'Generate next' >5. Nothing happens >6. APPLY PATCH >7. Try again, now the "Generate next" button should work as expected. >--- > .../prog/en/includes/modals/generate_next.inc | 21 +++++++++++++++++++ > .../en/modules/serials/serials-collection.tt | 11 ++++------ > 2 files changed, 25 insertions(+), 7 deletions(-) > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc >new file mode 100644 >index 0000000000..cc31c9edf5 >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/generate_next.inc >@@ -0,0 +1,21 @@ >+<div id="generate_next" class="modal" tabindex="-1" role="dialog" aria-labelledby="generate_next" aria-hidden="true"> >+ <div class="modal-dialog"> >+ <div class="modal-content"> >+ <form action="/cgi-bin/koha/serials/serials-collection.pl" method="post"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <div class="modal-body"> >+ <fieldset class="rows"> >+ <legend>Do you really want to generate next serial?</legend> >+ <input type="hidden" name="op" value="cud-gennext" /> >+ <input type="hidden" name="subscriptionid" value="[% subscriptionidlist || subscriptionid | html %]" /> >+ </fieldset> >+ </div> >+ >+ <div class="modal-footer"> >+ <a href="#" class="cancel" data-dismiss="modal" aria-hidden="true">Cancel</a> >+ <input type="submit" class="btn btn-default approve" value="Yes" /> >+ </div> >+ </form> >+ </div> >+ </div> >+</div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index d28b403f60..362e97b6e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -39,6 +39,9 @@ > > [% INCLUDE 'modals/serials_skip_issues.inc' %] > >+ [% INCLUDE 'modals/generate_next.inc' %] >+ >+ > [% UNLESS ( popup ) %] > [% INCLUDE 'serials-toolbar.inc' %] > >@@ -182,7 +185,7 @@ > <div class="btn-group"><input type="submit" value="Edit serials" class="btn btn-primary btn-sm" /></div> > [% UNLESS subscription.closed %] > <div class="btn-group"> >- <input type="button" value="Generate next" data-subscriptionid="[% subscriptionidlist | html %]" class="btn btn-default btn-sm generatenext" /> >+ <input type="button" value="Generate next" data-subscriptionid="[% subscriptionidlist | html %]" href="#generate_next" class="btn btn-default btn-sm" data-toggle="modal" /> > </div> > <div class="btn-group"> > <input type="button" value="Skip issues and generate next" data-subscriptionid="[% subscriptionidlist | html %]" href="#skip_issues" class="btn btn-default btn-sm" data-toggle="modal" /> >@@ -352,12 +355,6 @@ > } > } > >- function generateNext(subscriptionid) { >- if(confirm(_("Do you really want to generate next serial?"))){ >- document.location = 'serials-collection.pl?op=gennext&subscriptionid='+subscriptionid; >- } >- } >- > $(document).ready(function() { > if( $("#subscription_years .tab-pane.active").length < 1 ){ > $("#subscription_years a:first").tab("show"); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37294
:
168685
|
168727
|
169105