Bug 37294 - Generate next button in serials not working
Summary: Generate next button in serials not working
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-09 20:04 UTC by Lucas Gass (lukeg)
Modified: 2024-09-23 19:20 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the 'Generate next' button when receiving serials so that it now works as expected. Before this fix, nothing happened when clicking the button. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37294: Add modal to generate next (4.21 KB, patch)
2024-07-09 20:20 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37294: Add modal to generate next (4.26 KB, patch)
2024-07-10 13:22 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 37294: Add modal to generate next (4.32 KB, patch)
2024-07-17 16:25 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-07-09 20:04:23 UTC
To recreate:
1. Serials -> Create or find a subscription 
2. Receive the subscription 
3. Save
4. Click 'Generate next'
5. Nothing happens
Comment 1 Lucas Gass (lukeg) 2024-07-09 20:20:11 UTC
Created attachment 168685 [details] [review]
Bug 37294: Add modal to generate next

To test:
1. Serials -> Create or find a subscription
2. Receive the subscription
3. Save
4. Click 'Generate next'
5. Nothing happens
6. APPLY PATCH
7. Try again, now the "Generate next" button should work as expected.
Comment 2 ByWater Sandboxes 2024-07-10 13:22:44 UTC
Created attachment 168727 [details] [review]
Bug 37294: Add modal to generate next

To test:
1. Serials -> Create or find a subscription
2. Receive the subscription
3. Save
4. Click 'Generate next'
5. Nothing happens
6. APPLY PATCH
7. Try again, now the "Generate next" button should work as expected.

Signed-off-by: Kelly <kelly@bywatersoutions.com>
Comment 3 David Nind 2024-07-10 21:29:41 UTC
Hi Kelly.

It looks like you signed off, but the status is still "Needs Signoff".

If you can update the status, you will get the credit on the dashboard. 8-)

David
Comment 4 Kelly McElligott 2024-07-10 21:40:10 UTC
Got it! Thanks David!
Comment 5 Martin Renvoize (ashimema) 2024-07-17 16:25:17 UTC
Created attachment 169105 [details] [review]
Bug 37294: Add modal to generate next

To test:
1. Serials -> Create or find a subscription
2. Receive the subscription
3. Save
4. Click 'Generate next'
5. Nothing happens
6. APPLY PATCH
7. Try again, now the "Generate next" button should work as expected.

Signed-off-by: Kelly <kelly@bywatersoutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-07-17 16:25:43 UTC
Great to see this turning into a Modal whilst also fixing the reported problem, thanks Lucas

Passing QA
Comment 7 Katrin Fischer 2024-07-18 15:03:41 UTC
making_things_more_consistent++
Comment 8 Katrin Fischer 2024-07-18 15:57:20 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 CJ Lynce 2024-07-19 19:32:43 UTC
This is another bug we'd love to see squashed in 24.05. Thx!
Comment 10 Dani Elder 2024-07-24 19:19:34 UTC
Another plea for 24.05 backporting.
Comment 11 Lucas Gass (lukeg) 2024-07-24 20:08:52 UTC
This patch includes strings, so I can't backport it for 24.05.02 as we are already in string freeze. 

I'll pick it up first thing in the .03 cycle.
Comment 12 Lucas Gass (lukeg) 2024-09-06 15:56:43 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 13 Fridolin Somers 2024-09-17 13:51:27 UTC
Looks like this is CRSF related, not for 23.11.x
Comment 14 Lucas Gass (lukeg) 2024-09-19 14:57:26 UTC
Fixed a bug, nothing to document.