Attachment 169101 Details for Bug 32530 – Bug 32530: When duplicating child card, guarantor is not saved

[patch] Bug 32530: When duplicating child card, guarantor is not saved

Bug-32530-When-duplicating-child-card-guarantor-is.patch (text/plain), 3.02 KB, created by Martin Renvoize (ashimema) on 2024-07-17 16:18:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-17 16:18:16 UTC

Size: 3.02 KB

patch

obsolete

>From 1a0889a854cffdfea9f9594597b0ac775a6070d2 Mon Sep 17 00:00:00 2001
>From: Baptiste Wojtkowski <bski@laposte.net>
>Date: Thu, 11 Jul 2024 16:54:59 +0200
>Subject: [PATCH] Bug 32530: When duplicating child card, guarantor is not
> saved
>
>When duplicating a child card with a guarantor, the guarantor information
>appears during the card creation process, but disappears as soon as saving
>the card. To recreate:
>
>1. Find a card with a guarantor, either patron or non-patron guarantor.
>2. Duplicate the card. Note that it appears to be working on the card
>   creation screen.
>3. Save the patron after completing the form. The guarantor is now gone.
>
>New test plan:
>1. Find a card with a guarantor, either patron or non-patron guarantor.
>2. Duplicate the card. Note that it appears to be working on the card
>   creation screen.
>3. Save the patron after completing the form. The guarantor is now gone.
>Apply patch and repeat, the guarantor should stay after 3.
>
>Note, I may not have understood the code but it looks like nothing is
>searching for the content of the displayed information. Therefore I add
>hidden fields that are copies of those provided in guarantor_template
>class
>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt     | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 6877ef453f3..c12e44c3883 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -512,10 +512,12 @@ legend.collapsed i.fa.fa-caret-down::before {
>                                                                 <li class="guarantor-details" data-borrowernumber="[% r.guarantor_id | $raw %]">
>                                                                     <span class="label">Guarantor:</span>
>                                                                     [% INCLUDE 'patron-title.inc' patron=r.guarantor hide_patron_infos_if_needed=1 %]
>+                                                                    <input type="hidden" class="new_guarantor_id" name="new_guarantor_id" value="[% r.guarantor_id | $raw %]"/>
>                                                                 </li>
>                                                                 <li>
>                                                                     <span class="label">Relationship:</span>
>                                                                     <span>[% r.relationship | html %]</span>
>+                                                                    <input type=hidden class="new_guarantor_relationship" name="new_guarantor_relationship" value="[% r.relationship | html %]" />
>                                                                 </li>
> 
>                                                                 <li>
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 32530: 168833 | 168834 | 168873 | 169101