When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone.
Still valid in master (22.12.00.048)
Our library staff have noticed this bug, and it is causing extra steps during family card creation. We would like to see it fixed.
*** Bug 34763 has been marked as a duplicate of this bug. ***
Hi, I do not reproduce on main (v24.05.01), is it still valid ?
I finally reproduce on main, looking forward to fix it
It is still occurring on main (23.06). It does appear to work until you save the duplicated card, at which point the guarantor is not attached.
Created attachment 168833 [details] [review] Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class
Created attachment 168834 [details] [review] Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class
Created attachment 168873 [details] [review] Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Created attachment 169101 [details] [review] Bug 32530: When duplicating child card, guarantor is not saved When duplicating a child card with a guarantor, the guarantor information appears during the card creation process, but disappears as soon as saving the card. To recreate: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. New test plan: 1. Find a card with a guarantor, either patron or non-patron guarantor. 2. Duplicate the card. Note that it appears to be working on the card creation screen. 3. Save the patron after completing the form. The guarantor is now gone. Apply patch and repeat, the guarantor should stay after 3. Note, I may not have understood the code but it looks like nothing is searching for the content of the displayed information. Therefore I add hidden fields that are copies of those provided in guarantor_template class Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the fix guys, Passing QA
Pushed for 24.11! Well done everyone, thank you!
This introduced a critical issue when editing patron, see bug 37881. Please fix ASAP.
BAckported to 24.05.x for upcoming 24.05.05
(In reply to Jonathan Druart from comment #13) > This introduced a critical issue when editing patron, see bug 37881. Please > fix ASAP. Bug 37881 currently only in main so I do not backport this one. @Lucas revert this one or backport also Bug 37881