Bugzilla – Attachment 169154 Details for
Bug 37371
Direct input of dates not working when editing only part of a date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37371: Move Maskito instantiation to onReady ( OPAC )
Bug-37371-Move-Maskito-instantiation-to-onReady--O.patch (text/plain), 2.25 KB, created by
Kyle M Hall (khall)
on 2024-07-18 16:54:58 UTC
(
hide
)
Description:
Bug 37371: Move Maskito instantiation to onReady ( OPAC )
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-07-18 16:54:58 UTC
Size:
2.25 KB
patch
obsolete
>From 3f7dbd638ab7831bf4a050debdb6c8959fcde144 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 17 Jul 2024 15:10:24 +0000 >Subject: [PATCH] Bug 37371: Move Maskito instantiation to onReady ( OPAC ) > >To test: >1. Find a any date picker in Koha, like DOB in the patron record. >2. Add a date, either manually or using the date picker. >3. Once there is a date like 07/15/2024 try to edit only part of the > date, or the '15'. >4. The date easily becomes malformed. >5. APPLY PATCHSET, maybe clear your browser cache too >6. Try directly inputing dates. I would suggest the following places: > >-Patron record DOB >-Specify due date on circ/circulation.pl as this includes time >-Add item screen, this is the dateaccessioned plugin >-OPAC self reg/self modify > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../bootstrap/en/includes/calendar.inc | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc >index cb8ec7804e3..edd8ba565cb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc >@@ -102,15 +102,16 @@ > instance.set('allowInput',false); > } > }); >- }, >- onOpen: function( selectedDates, dateText, instance ) { >- var thisInput = instance.input; >- let options = maskitoDateOptionsGenerator({ >- mode: altinput_dateformat, >- separator: delimiter, >- }); > >- new Maskito( instance.altInput, options ); >+ /* When flatpickr instance is ready, add maskito input mask */ >+ var thisInput = instance.input; >+ let options = maskitoDateOptionsGenerator({ >+ mode: altinput_dateformat, >+ separator: delimiter, >+ overwriteMode: 'replace', >+ }); >+ >+ new Maskito( instance.altInput, options ); > }, > onClose: function( selectedDates, dateText, instance) { > validate_date( dateText, instance ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37371
:
169083
|
169085
|
169086
|
169087
|
169088
|
169094
|
169135
|
169136
|
169137
|
169138
|
169151
|
169152
|
169153
| 169154