Bug 37371 - Direct input of dates not working when editing only part of a date
Summary: Direct input of dates not working when editing only part of a date
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Martin Renvoize (ashimema)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 33703
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-16 13:34 UTC by Lucas Gass (lukeg)
Modified: 2024-09-10 20:14 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37371: Move Maskito instantiation to onReady (3.30 KB, patch)
2024-07-17 14:09 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37371: Set overwrite mode to replace (1.23 KB, patch)
2024-07-17 14:51 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl (1.29 KB, patch)
2024-07-17 14:59 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl (1.32 KB, patch)
2024-07-17 15:05 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady ( OPAC ) (2.14 KB, patch)
2024-07-17 15:14 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady ( OPAC ) (2.20 KB, patch)
2024-07-17 15:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady (3.34 KB, patch)
2024-07-18 14:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37371: Set overwrite mode to replace (1.28 KB, patch)
2024-07-18 14:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl (1.37 KB, patch)
2024-07-18 14:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady ( OPAC ) (2.20 KB, patch)
2024-07-18 14:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady (3.40 KB, patch)
2024-07-18 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37371: Set overwrite mode to replace (1.34 KB, patch)
2024-07-18 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl (1.42 KB, patch)
2024-07-18 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37371: Move Maskito instantiation to onReady ( OPAC ) (2.25 KB, patch)
2024-07-18 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-07-16 13:34:46 UTC
To recreate:

1. Find a any date picker in Koha, like DOB in the patron record.
2. Add a date, either manually or using the date picker.
3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 
4. The date easily becomes malformed. 

I searched for bugs related to this with Maskito. Unfortunatly I think the Maskito libray and feature needs to be removed. See Bug 33703
Comment 1 Lucas Gass (lukeg) 2024-07-16 15:56:53 UTC
So the Maskito mark works fine in dateaccessioned.pl plugin on additem.tt, so I think something in calendar.inc may be causing the problem.
Comment 2 Katrin Fischer 2024-07-17 07:46:37 UTC
I am updating severity as this is also an accessibility issue. The direct input is much easier than using the calendar widget for some.
Comment 3 Martin Renvoize (ashimema) 2024-07-17 10:53:14 UTC
Could you catch me and demo what you're seeing Lucas?

I just tried and I can't get the date to malform but maybe I'm not seeing what you are.
Comment 4 Martin Renvoize (ashimema) 2024-07-17 14:09:28 UTC Comment hidden (obsolete)
Comment 5 Lucas Gass (lukeg) 2024-07-17 14:51:56 UTC Comment hidden (obsolete)
Comment 6 Lucas Gass (lukeg) 2024-07-17 14:59:17 UTC Comment hidden (obsolete)
Comment 7 Lucas Gass (lukeg) 2024-07-17 15:05:20 UTC Comment hidden (obsolete)
Comment 8 Lucas Gass (lukeg) 2024-07-17 15:14:04 UTC Comment hidden (obsolete)
Comment 9 Lucas Gass (lukeg) 2024-07-17 15:14:32 UTC
Thank you Martin for figuring this one out!
Comment 10 Owen Leonard 2024-07-17 15:47:53 UTC Comment hidden (obsolete)
Comment 11 Owen Leonard 2024-07-18 14:24:48 UTC
Created attachment 169135 [details] [review]
Bug 37371: Move Maskito instantiation to onReady

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2024-07-18 14:24:50 UTC
Created attachment 169136 [details] [review]
Bug 37371: Set overwrite mode to replace

In our case I think overwriteMode needs to be set to replace:

https://maskito.dev/core-concepts/overwrite-mode
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Owen Leonard 2024-07-18 14:24:52 UTC
Created attachment 169137 [details] [review]
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2024-07-18 14:24:54 UTC
Created attachment 169138 [details] [review]
Bug 37371: Move Maskito instantiation to onReady ( OPAC )

To test:
1. Find a any date picker in Koha, like DOB in the patron record.
2. Add a date, either manually or using the date picker.
3. Once there is a date like 07/15/2024 try to edit only part of the
   date, or the '15'.
4. The date easily becomes malformed.
5. APPLY PATCHSET, maybe clear your browser cache too
6. Try directly inputing dates. I would suggest the following places:

-Patron record DOB
-Specify due date on circ/circulation.pl as this includes time
-Add item screen, this is the dateaccessioned plugin
-OPAC self reg/self modify

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Kyle M Hall (khall) 2024-07-18 16:54:46 UTC
Created attachment 169151 [details] [review]
Bug 37371: Move Maskito instantiation to onReady

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 16 Kyle M Hall (khall) 2024-07-18 16:54:54 UTC
Created attachment 169152 [details] [review]
Bug 37371: Set overwrite mode to replace

In our case I think overwriteMode needs to be set to replace:

https://maskito.dev/core-concepts/overwrite-mode
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 17 Kyle M Hall (khall) 2024-07-18 16:54:56 UTC
Created attachment 169153 [details] [review]
Bug 37371: Move Maskito init to onReady in dateaccessioned.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 18 Kyle M Hall (khall) 2024-07-18 16:54:58 UTC
Created attachment 169154 [details] [review]
Bug 37371: Move Maskito instantiation to onReady ( OPAC )

To test:
1. Find a any date picker in Koha, like DOB in the patron record.
2. Add a date, either manually or using the date picker.
3. Once there is a date like 07/15/2024 try to edit only part of the
   date, or the '15'.
4. The date easily becomes malformed.
5. APPLY PATCHSET, maybe clear your browser cache too
6. Try directly inputing dates. I would suggest the following places:

-Patron record DOB
-Specify due date on circ/circulation.pl as this includes time
-Add item screen, this is the dateaccessioned plugin
-OPAC self reg/self modify

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 19 Martin Renvoize (ashimema) 2024-07-22 06:38:10 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 20 Lucas Gass (lukeg) 2024-08-28 19:35:06 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 21 Fridolin Somers 2024-09-10 11:41:40 UTC
Depends on Bug 33703 not in 23.11.x
Comment 22 Caroline Cyr La Rose 2024-09-10 20:14:57 UTC
This looks like a bug fix, nothing to change/edit in the manual. Please reopen with more details if needed.