Attachment 169208 Details for Bug 37400 – Bug 37400 - In returns.pl don't search for a patron unless needed

[patch] Bug 37400 - In returns.pl don't search for a patron unless needed

Bug-37400---In-returnspl-dont-search-for-a-patron-.patch (text/plain), 1.25 KB, created by Martin Renvoize (ashimema) on 2024-07-19 12:11:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-19 12:11:14 UTC

Size: 1.25 KB

patch

obsolete

>From 1a346d8b62408b1c489ec3074159ed2636adad36 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 18 Jul 2024 07:27:47 -0400
>Subject: [PATCH] Bug 37400 - In returns.pl don't search for a patron unless
> needed
>
>In returns.pl we find a patron, then use it in an if statement.
>
>Test Plan:
>Cancel a hold with other holds remaining on the record.
>No change should be noted.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> circ/returns.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 019d8e36c84..2f596e052aa 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -179,8 +179,8 @@ if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve') {
>     # FIXME do we need to do this if we didn't take the cancel_reserve branch above?
>     my ( undef, $nextreservinfo, undef ) = CheckReserves($item);
> 
>-    my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} );
>     if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) {
>+        my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} );
>         $template->param(
>             itemtitle      => $biblio->title,
>             itembiblionumber => $biblio->biblionumber,
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37400: 169128 | 169208