Bug 37400 - On checkin don't search for a patron unless needed
Summary: On checkin don't search for a patron unless needed
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Kyle M Hall (khall)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-18 11:26 UTC by Kyle M Hall (khall)
Modified: 2024-09-18 04:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:

Attachments
Bug 37400 - In returns.pl don't search for a patron unless needed (1.15 KB, patch)
2024-07-18 11:29 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 37400 - In returns.pl don't search for a patron unless needed (1.25 KB, patch)
2024-07-19 12:11 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2024-07-18 11:26:35 UTC 
In returns.pl we find a patron, then use it in an if statement.
Comment 1 Kyle M Hall (khall) 2024-07-18 11:29:19 UTC 
Created attachment 169128 [details] [review]
Bug 37400 - In returns.pl don't search for a patron unless needed

In returns.pl we find a patron, then use it in an if statement.

Test Plan:
Cancel a hold with other holds remaining on the record.
No change should be noted.
Comment 2 Martin Renvoize (ashimema) 2024-07-19 12:11:14 UTC 
Created attachment 169208 [details] [review]
Bug 37400 - In returns.pl don't search for a patron unless needed

In returns.pl we find a patron, then use it in an if statement.

Test Plan:
Cancel a hold with other holds remaining on the record.
No change should be noted.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2024-07-19 12:11:46 UTC 
Straight QA, simple improvement.
Comment 4 Martin Renvoize (ashimema) 2024-07-22 09:41:07 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Fridolin Somers 2024-09-10 13:34:05 UTC 
I see it is in 24.05.x for v24.05.04
Comment 6 Fridolin Somers 2024-09-10 13:35:47 UTC 
Oupsy commit message syntax is wrong :
- Bug 37400 - In returns.pl
+ Bug 37400: In returns.pl
Comment 7 Fridolin Somers 2024-09-10 13:38:51 UTC 
Pushed to 23.11.x for 23.11.09
Comment 8 Wainui Witika-Park 2024-09-18 04:01:35 UTC 
Not backporting to 23.05.x unless requested