Attachment 169427 Details for Bug 37304 – Bug 37304: Fix created by filter in Acquisitions advanced search

[patch] Bug 37304: Fix created by filter in Acquisitions advanced search

Bug-37304-Fix-created-by-filter-in-Acquisitions-ad.patch (text/plain), 1.61 KB, created by Roman Dolny on 2024-07-23 14:45:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Dolny

Created: 2024-07-23 14:45:27 UTC

Size: 1.61 KB

patch

obsolete

>From 7ec00df0b72c6c801172718478f556dd09838f4a Mon Sep 17 00:00:00 2001
>From: Brendan Lawlor <blawlor@clamsnet.org>
>Date: Mon, 22 Jul 2024 20:07:18 +0000
>Subject: [PATCH] Bug 37304: Fix created by filter in Acquisitions advanced
> search
>
>This patch updates the field for the created by filter from
>ui.item.borrowernumber to ui.item.patron_id
>
>Test plan:
>1. Add a vendor and a basket
>2. Use advanced order search to search for created by 'koha'
>3. Use the autofill dropdown to make the selection and click 'Search'
>4. Your search returned no results.
>5. Apply patch and repeat steps 2 and 3
>6. Confirm the search returns the basket you created earlier
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>index 4c2e5b17fc..37404fd64e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
>@@ -184,7 +184,7 @@
>             }
>             patron_autocomplete($("#find_patron"), {
>                 'on-select-callback': function( event, ui ) {
>-                    var field = ui.item.borrowernumber;
>+                    var field = ui.item.patron_id;
>                     AddPatron( ui.item.firstname + " " + ( ui.item.middle_name || "" ) + " " + ui.item.surname, field, $("#basket_creators"), 'created_by' );
>                     $("#find_patron").val('').focus();
>                     return false;
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37304: 169383 | 169427 | 172938