Bug 37304 - The Created by filter in Acquisitions advanced orders search always shows zero results
Summary: The Created by filter in Acquisitions advanced orders search always shows zer...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 23.11
Hardware: All All
: P5 - low minor
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 11:00 UTC by Lucy Vaux-Harvey
Modified: 2024-07-23 14:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37304: Fix created by filter in Acquisitions advanced search (1.56 KB, patch)
2024-07-22 20:14 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 37304: Fix created by filter in Acquisitions advanced search (1.61 KB, patch)
2024-07-23 14:45 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucy Vaux-Harvey 2024-07-10 11:00:28 UTC
In the Order Search screen, the Basket Created By field results in 0 (zero) hits regardless of which member of staff is selected.

To recreate:
Go to Acquisitions then to Advanced Search from the left hand menu options
In the Basket Created By field begin entering name of staff member who has baskets created in the system
Select name from the suggestions dropdown, name is added beneath the search box
Click Search

Even though there are baskets created by this user zero results are returned with the message "Your search returned no results."
Comment 1 Brendan Lawlor 2024-07-22 20:14:09 UTC
Created attachment 169383 [details] [review]
Bug 37304: Fix created by filter in Acquisitions advanced search

This patch updates the field for the created by filter from
ui.item.borrowernumber to ui.item.patron_id

Test plan:
1. Add a vendor and a basket
2. Use advanced order search to search for created by 'koha'
3. Use the autofill dropdown to make the selection and click 'Search'
4. Your search returned no results.
5. Apply patch and repeat steps 2 and 3
6. Confirm the search returns the basket you created earlier
Comment 2 Roman Dolny 2024-07-23 14:45:27 UTC
Created attachment 169427 [details] [review]
Bug 37304: Fix created by filter in Acquisitions advanced search

This patch updates the field for the created by filter from
ui.item.borrowernumber to ui.item.patron_id

Test plan:
1. Add a vendor and a basket
2. Use advanced order search to search for created by 'koha'
3. Use the autofill dropdown to make the selection and click 'Search'
4. Your search returned no results.
5. Apply patch and repeat steps 2 and 3
6. Confirm the search returns the basket you created earlier

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>