In the Order Search screen, the Basket Created By field results in 0 (zero) hits regardless of which member of staff is selected. To recreate: Go to Acquisitions then to Advanced Search from the left hand menu options In the Basket Created By field begin entering name of staff member who has baskets created in the system Select name from the suggestions dropdown, name is added beneath the search box Click Search Even though there are baskets created by this user zero results are returned with the message "Your search returned no results."
Created attachment 169383 [details] [review] Bug 37304: Fix created by filter in Acquisitions advanced search This patch updates the field for the created by filter from ui.item.borrowernumber to ui.item.patron_id Test plan: 1. Add a vendor and a basket 2. Use advanced order search to search for created by 'koha' 3. Use the autofill dropdown to make the selection and click 'Search' 4. Your search returned no results. 5. Apply patch and repeat steps 2 and 3 6. Confirm the search returns the basket you created earlier
Created attachment 169427 [details] [review] Bug 37304: Fix created by filter in Acquisitions advanced search This patch updates the field for the created by filter from ui.item.borrowernumber to ui.item.patron_id Test plan: 1. Add a vendor and a basket 2. Use advanced order search to search for created by 'koha' 3. Use the autofill dropdown to make the selection and click 'Search' 4. Your search returned no results. 5. Apply patch and repeat steps 2 and 3 6. Confirm the search returns the basket you created earlier Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 172938 [details] [review] Bug 37304: Fix created by filter in Acquisitions advanced search This patch updates the field for the created by filter from ui.item.borrowernumber to ui.item.patron_id Test plan: 1. Add a vendor and a basket 2. Use advanced order search to search for created by 'koha' 3. Use the autofill dropdown to make the selection and click 'Search' 4. Your search returned no results. 5. Apply patch and repeat steps 2 and 3 6. Confirm the search returns the basket you created earlier Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Looks like it dates from Bug 30578 And we also need to fix : koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt
Pushed to 23.11.x for 23.11.11
(In reply to Fridolin Somers from comment #6) > Looks like it dates from Bug 30578 > > And we also need to fix : > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt Thanks Frido! I created a bug 38698 for the Acquisitions duplicate order search
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.