Bugzilla – Attachment 169522 Details for
Bug 30519
Using CircConfirmItemParts prevents checkin from patron account in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30519: Show Checkin box even if CircConfirmParts is enabled
Bug-30519-Show-Checkin-box-even-if-CircConfirmPart.patch (text/plain), 2.61 KB, created by
Laura Escamilla
on 2024-07-24 21:35:06 UTC
(
hide
)
Description:
Bug 30519: Show Checkin box even if CircConfirmParts is enabled
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2024-07-24 21:35:06 UTC
Size:
2.61 KB
patch
obsolete
>From 6560d9598a59741c8e932ab217b9196f9ffb6e19 Mon Sep 17 00:00:00 2001 >From: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >Date: Wed, 24 Jul 2024 21:31:02 +0000 >Subject: [PATCH] Bug 30519: Show Checkin box even if CircConfirmParts is > enabled >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. Set the system preference CircConfirmItemParts to require confirmation >2. Add a materials specified note to an item. >3. Check the item out to a patron, confirming the note. >4. Go to patron record, either moremember or circulation >5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in. >6. Apply the patch and restart_all. Also clear your cache. >7. Make sure you have the item with the material specified note still checked out. >8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note. >9. Click on the checkin box. The âCheck in selected itemsâ button now becomes usable. Click on it and notice that the item is now successfully checked in. >10. Sign off and have an amazing day! :D >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index a2b540e971..88fe5afd7f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -367,10 +367,12 @@ function LoadIssuesTable() { > return "<a href='/cgi-bin/koha/recalls/request.pl?biblionumber=" + oObj.biblionumber + "'>" + __("Recalled") + "</a>"; > } else if ( oObj.can_renew_error == "on_reserve" ) { > return "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + __("On hold") + "</a>"; >- } else if ( oObj.materials ) { >- return __("Confirm (%s)".format(oObj.materials.escapeHtml())); > } else { >- return "<input type='checkbox' class='checkin' id='checkin_" + oObj.itemnumber + "' name='checkin' value='" + oObj.itemnumber +"'></input>"; >+ var content = "<input type='checkbox' class='checkin' id='checkin_" + oObj.itemnumber + "' name='checkin' value='" + oObj.itemnumber + "'></input>"; >+ if (oObj.materials) { >+ content += __("Confirm (%s)").format(oObj.materials.escapeHtml()); >+ } >+ return content; > } > } > }, >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30519
:
169522
|
169558