Bug 30519 - Using CircConfirmItemParts prevents checkin from patron account in staff interface
Summary: Using CircConfirmItemParts prevents checkin from patron account in staff inte...
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Laura Escamilla
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
: 34714 (view as bug list)
Depends on: 25261
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-13 00:23 UTC by Donna
Modified: 2024-08-13 13:06 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 30519: Show Checkin box even if CircConfirmParts is enabled (2.61 KB, patch)
2024-07-24 21:35 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 30519: Show Checkin box even if CircConfirmParts is enabled (2.67 KB, patch)
2024-07-25 14:20 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2022-04-13 00:23:08 UTC
With the addition of bug 25261, utilizing the sys pref CircConfirmItemParts and materials specified 952$3, you can no longer use the Check In column on either the morememeber.pl or circulation.pl.  

To test:
--set sys pref to require confirmation
--add a materials specified note to an item
--check item out to a patron, confirming the note
--go to patron record, either moremember or circulation
--using the Check In column, attempt to check in the item
--notice no confirmation box, and item is not checked in
Comment 1 Andrew Fuerste-Henry 2023-10-11 15:23:46 UTC
This regression is still present and still frustrating. Check-ins fail with no message to the user.
Comment 2 Katrin Fischer 2023-10-16 20:52:48 UTC
I am not sure this is a regression as it was introduced with a new and optional feature. I am not sure how hard it is to fix this as we don't trigger any modals or alerts from the checkouts/details right now.
Comment 3 Katrin Fischer 2023-10-28 20:49:40 UTC
*** Bug 34714 has been marked as a duplicate of this bug. ***
Comment 4 Laura Escamilla 2024-07-24 21:35:06 UTC
Created attachment 169522 [details] [review]
Bug 30519: Show Checkin box even if CircConfirmParts is enabled

To test:
1. Set the system preference CircConfirmItemParts to require confirmation
2. Add a materials specified note to an item.
3. Check the item out to a patron, confirming the note.
4. Go to patron record, either moremember or circulation
5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in.
6. Apply the patch and restart_all. Also clear your cache.
7. Make sure you have the item with the material specified note still checked out.
8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note.
9. Click on the checkin box. The “Check in selected items” button now becomes usable. Click on it and notice that the item is now successfully checked in.
10. Sign off and have an amazing day! :D
Comment 5 ByWater Sandboxes 2024-07-25 14:20:06 UTC
Created attachment 169558 [details] [review]
Bug 30519: Show Checkin box even if CircConfirmParts is enabled

To test:
1. Set the system preference CircConfirmItemParts to require confirmation
2. Add a materials specified note to an item.
3. Check the item out to a patron, confirming the note.
4. Go to patron record, either moremember or circulation
5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in.
6. Apply the patch and restart_all. Also clear your cache.
7. Make sure you have the item with the material specified note still checked out.
8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note.
9. Click on the checkin box. The “Check in selected items” button now becomes usable. Click on it and notice that the item is now successfully checked in.
10. Sign off and have an amazing day! :D

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 6 Andrew Fuerste-Henry 2024-07-25 14:28:50 UTC
I'm signing off on this because it accomplishes the stated goal.

It does not explicitly force the user to confirm that they have read the materials specified note. It makes the user check the box for the item they wish to check in, and the materials specified note is right next to that box, but that does feel a little bit less explicit. If my patron has multiple items checked out and only one of them has a materials specified note it seems really easy to just click "Select all" and check all those items in without thinking about the note at all.

But I feel like I might be over-worrying. So I'm signing off but putting this in a comment for others to ponder while I have my amazing day, as directed:)
Comment 7 Emily Lamancusa (emlam) 2024-07-25 16:31:20 UTC
This solution does seem to present a loophole to the stated purpose of CircConfirmItemParts. The intended behavior when the user attempts to check in an item with specified materials from the checkout table was to reload the table with a warning on that item, highlighted in yellow with a checkbox to explicitly confirm the included materials (see bug 25261#c75).

Seems like that error handling got lost somewhere (see bug 25261#c211 and bug 34302), but adding it back in should fix this bug while preserving the intent of CircConfirmItemParts.
Comment 8 Katrin Fischer 2024-07-29 13:11:16 UTC
I agree with Emily that we expect a confirmation step here and that this previous behavior should be brought back.
Comment 9 Laura Escamilla 2024-07-29 13:16:19 UTC
I will work on updating this and will get a new patch out soon!