Attachment 169935 Details for Bug 37288 – Bug 37288: Allow manual providers to be edited

[patch] Bug 37288: Allow manual providers to be edited

Bug-37288-Allow-manual-providers-to-be-edited.patch (text/plain), 2.15 KB, created by Martin Renvoize (ashimema) on 2024-08-01 10:58:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-08-01 10:58:46 UTC

Size: 2.15 KB

patch

obsolete

>From d63839b6f1f90258ae5fdf70d25f5c976b17d6e4 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 29 Jul 2024 08:52:39 +0000
>Subject: [PATCH] Bug 37288: Allow manual providers to be edited
>
>There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually
>
>Test plan:
>1) Create a data provider in the ERM manually using the Create manually option
>2) Click to edit that provider
>3) The form will not load
>4) Apply patch and run yarn build
>5) Hard refresh the browser
>6) The form should now load correctly
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../components/ERM/UsageStatisticsDataProvidersFormAdd.vue    | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
>index 8311922e2b2..b205956d2da 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
>@@ -455,7 +455,7 @@ export default {
>             client.counter_registry.getAll({ name: query }).then(
>                 registry_data => {
>                     this.registry_data = registry_data
>-                    if (caller === "edit") {
>+                    if (caller === "edit" && registry_data.length > 0) {
>                         this.selected_provider = registry_data.find(
>                             platform =>
>                                 platform.name === this.usage_data_provider.name
>@@ -466,6 +466,8 @@ export default {
>                                     r => r.report_id === report.value
>                                 )
>                             )
>+                    } else {
>+                        this.manual_form = true
>                     }
>                     this.searching = false
>                     this.initialized = true
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37288: 169074 | 169793 | 169811 | 169816 | 169817 | 169934 | 169935