I think bug 34587 introduced this bug. If you create a data provider then edit it, the edit form will not display the name, and the input is looking like the add form. You also see the "Create manually" button, which feels wrong. See https://snipboard.io/ELqPAB.jpg
Created attachment 169074 [details] [review] Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible
Created attachment 169793 [details] [review] Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com>
I had signed off, but then did some more testing. If I create a data provider manually (either before or after the patch), when I go to edit it, it just stays on the page with "Loading" displayed at the top of the page body. Also, other pages that have "Loading" have it in the page center with a blue background. Should this do the same here? While I'm not that familiar with ERM and eUsage, would you ever want to change a manually created provider to one from the registry? Or vice versa? I think the answer is no, but just wante dto check.
Created attachment 169811 [details] [review] Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly
Created attachment 169816 [details] [review] Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com>
Created attachment 169817 [details] [review] Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly Signed-off-by: David Nind <david@davidnind.com>
Created attachment 169934 [details] [review] Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 169935 [details] [review] Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested