Bug 37288 - Edit data provider form does not show the name
Summary: Edit data provider form does not show the name
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Matt Blenkinsop
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 34587
Blocks: 37607
  Show dependency tree / graph
 
Reported: 2024-07-09 12:54 UTC by Jonathan Druart
Modified: 2024-09-18 06:38 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the editing form for eUsage data providers (ERM > eUsage > Data providers): - It delays the page display until the information from the counter registry is received. Previously, the data provider name was empty until the data from the registry was received. - It removes the 'Create manually' button when editing a data provider that was created from the registry.
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:

Attachments
Bug 37288: Improve display of data provider edit form (3.22 KB, patch)
2024-07-17 08:42 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 37288: Improve display of data provider edit form (3.25 KB, patch)
2024-07-27 00:29 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37288: Allow manual providers to be edited (2.05 KB, patch)
2024-07-29 08:55 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 37288: Improve display of data provider edit form (3.25 KB, patch)
2024-07-29 09:58 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37288: Allow manual providers to be edited (2.08 KB, patch)
2024-07-29 09:58 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37288: Improve display of data provider edit form (3.32 KB, patch)
2024-08-01 10:58 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 37288: Allow manual providers to be edited (2.15 KB, patch)
2024-08-01 10:58 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-07-09 12:54:50 UTC 
I think bug 34587 introduced this bug.

If you create a data provider then edit it, the edit form will not display the name, and the input is looking like the add form.
You also see the "Create manually" button, which feels wrong.

See https://snipboard.io/ELqPAB.jpg
Comment 1 Matt Blenkinsop 2024-07-17 08:42:56 UTC 
Created attachment 169074 [details] [review]
Bug 37288: Improve display of data provider edit form

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible
Comment 2 David Nind 2024-07-27 00:29:51 UTC 
Created attachment 169793 [details] [review]
Bug 37288: Improve display of data provider edit form

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-07-27 01:02:28 UTC 
I had signed off, but then did some more testing.

If I create a data provider manually (either before or after the patch), when I go to edit it, it just stays on the page with "Loading" displayed at the top of the page body.

Also, other pages that have "Loading" have it in the page center with a blue background. Should this do the same here?

While I'm not that familiar with ERM and eUsage, would you ever want to change a manually created provider to one from the registry? Or vice versa? I think the answer is no, but just wante dto check.
Comment 4 Matt Blenkinsop 2024-07-29 08:55:58 UTC 
Created attachment 169811 [details] [review]
Bug 37288: Allow manual providers to be edited

There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually

Test plan:
1) Create a data provider in the ERM manually using the Create manually option
2) Click to edit that provider
3) The form will not load
4) Apply patch and run yarn build
5) Hard refresh the browser
6) The form should now load correctly
Comment 5 David Nind 2024-07-29 09:58:19 UTC 
Created attachment 169816 [details] [review]
Bug 37288: Improve display of data provider edit form

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2024-07-29 09:58:21 UTC 
Created attachment 169817 [details] [review]
Bug 37288: Allow manual providers to be edited

There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually

Test plan:
1) Create a data provider in the ERM manually using the Create manually option
2) Click to edit that provider
3) The form will not load
4) Apply patch and run yarn build
5) Hard refresh the browser
6) The form should now load correctly

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Martin Renvoize (ashimema) 2024-08-01 10:58:43 UTC 
Created attachment 169934 [details] [review]
Bug 37288: Improve display of data provider edit form

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize (ashimema) 2024-08-01 10:58:46 UTC 
Created attachment 169935 [details] [review]
Bug 37288: Allow manual providers to be edited

There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually

Test plan:
1) Create a data provider in the ERM manually using the Create manually option
2) Click to edit that provider
3) The form will not load
4) Apply patch and run yarn build
5) Hard refresh the browser
6) The form should now load correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Katrin Fischer 2024-08-01 16:27:20 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 10 Lucas Gass (lukeg) 2024-08-29 17:28:55 UTC 
Backported to 24.05.x for 24.05.04
Comment 11 Fridolin Somers 2024-09-16 14:47:54 UTC 
Pushed to 23.11.x for 23.11.09
Comment 12 Wainui Witika-Park 2024-09-18 06:38:54 UTC 
Not backporting to 23.05.x unless requested