Attachment 170307 Details for Bug 37309 – Bug 37309: Clear itemnumbers array before 'select all'

[patch] Bug 37309: Clear itemnumbers array before 'select all'

Bug-37309-Clear-itemnumbers-array-before-select-al.patch (text/plain), 1.41 KB, created by Jonathan Druart on 2024-08-14 08:28:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-08-14 08:28:56 UTC

Size: 1.41 KB

patch

obsolete

>From 246f483fed901d71161465a5377a30e0a71df1fa Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 11 Jul 2024 14:47:09 +0200
>Subject: [PATCH] Bug 37309: Clear itemnumbers array before 'select all'
>
>Otherwise the same itemnumber can appear several times in the array.
>It could be moved to its own bug but this is only code cleaning it
>seems, there is no impact on the UX
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc   | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 737e3a0a922..03f248234c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -130,6 +130,7 @@
>                 e.preventDefault();
>                 let tab_id = $(this).data("tab");
>                 let tab = $("#" + tab_id + "_panel" );
>+                items_selection[tab_id] = [];
>                 tab.find("input[name='itemnumber'][type='checkbox']").each( (i, input) => {
>                     let itemnumber = parseInt($(input).val());
>                     items_selection[tab_id].push(itemnumber);
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37309: 168777 | 168797 | 168798 | 168799 | 168802 | 168844 | 168845 | 168846 | 168847 | 168848 | 170307 | 170309 | 170700