Bugzilla – Attachment 170345 Details for
Bug 37649
Unnecessary import in KBART import background job
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37649: Remove unneccessary JSON import
Bug-37649-Remove-unneccessary-JSON-import.patch (text/plain), 1.05 KB, created by
Matt Blenkinsop
on 2024-08-15 10:19:19 UTC
(
hide
)
Description:
Bug 37649: Remove unneccessary JSON import
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-08-15 10:19:19 UTC
Size:
1.05 KB
patch
obsolete
>From 4a542c869b30787454b40d397a57eecf440b6155 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Thu, 15 Aug 2024 10:17:10 +0000 >Subject: [PATCH] Bug 37649: Remove unneccessary JSON import > >This patch removes an unncessary import of the JSON module in the KBART import background job > >Test plan: >1) Look at the patch diff and note the removal of the import >2) Run t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t >--- > Koha/BackgroundJob/ImportKBARTFile.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/Koha/BackgroundJob/ImportKBARTFile.pm b/Koha/BackgroundJob/ImportKBARTFile.pm >index 890a3c926a8..ca76d1a8e3a 100644 >--- a/Koha/BackgroundJob/ImportKBARTFile.pm >+++ b/Koha/BackgroundJob/ImportKBARTFile.pm >@@ -16,7 +16,6 @@ package Koha::BackgroundJob::ImportKBARTFile; > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use JSON qw( decode_json encode_json ); > use Try::Tiny qw( catch try ); > use MIME::Base64 qw( decode_base64 ); > use POSIX qw( floor ); >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37649
:
170345
|
170355