Attachment 170420 Details for Bug 37615 – Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification

[patch] Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification

Bug-37615-Clean-up-the-form-for-sending-cardnumber.patch (text/plain), 2.99 KB, created by David Nind on 2024-08-16 03:17:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-08-16 03:17:23 UTC

Size: 2.99 KB

patch

obsolete

>From cc50d767be9186a75353219e9416905db3dd6ac8 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Thu, 15 Aug 2024 15:11:44 -0700
>Subject: [PATCH] Bug 37615: Clean up the form for sending cardnumbers from a
> report to batch patron modification
>
>Since bug 37197 switched reports back to using a POST to send cardnumbers to
>batch modification, we should also be using a single textarea rather than
>multiple inputs.
>
>Test plan:
>1. Reports - Create from SQL - give it a name, and the SQL
>   select cardnumber from borrowers limit 3
>2. Save report - Run report
>3. Batch operations with 3 visible records - Batch patron modification
>4. Verify that you have the same three cardnumbers in Batch patron modification
>   as were in the report.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt       | 8 ++++----
> tools/modborrowers.pl                                     | 2 --
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 9dd38ba53b..e719677ccd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1012,10 +1012,10 @@
>                                     [%- END -%]
>                                     [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim | html %]
>                                     [% IF !batch_borrowernumbers && cardnumbers %]
>-                                        [% SET batch_cardnumbers = cardnumbers.length %]
>-                                        [% FOR b IN cardnumbers.split("\n") %]
>-                                            <input type="hidden" name="cardnumber" value="[% b | uri %]" />
>-                                        [% END -%]
>+                                        [% SET batch_cardnumbers = 1 %]
>+                                        <textarea style="display:none;" name="cardnumberlist" id="cardnumberlist">
>+                                        [%- cardnumbers | html -%]
>+                                        </textarea>
>                                     [% END %]
> 
>                                 </form>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 502c1e0fa5..006d219275 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -66,8 +66,6 @@ if ( $op eq 'cud-show' ) {
>     if( my $cardnumberlist = $input->param('cardnumberlist') ){
>         # User submitted a list of card numbers
>         push @patronidnumbers, split( /\s\n/, $cardnumberlist );
>-    } elsif ( my @cardnumbers = $input->multi_param('cardnumber') ) {
>-        @patronidnumbers = @cardnumbers;
>     } elsif ( my $cardnumberuploadfile = $input->param('cardnumberuploadfile') ){
>         # User uploaded a file of card numbers
>         binmode $cardnumberuploadfile, ':encoding(UTF-8)';
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37615: 170413 | 170420 | 170447